From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs <linux-xfs@vger.kernel.org>, Eric Sandeen <sandeen@redhat.com>
Subject: Re: [PATCH] xfs: move error injection tags into their own file
Date: Tue, 31 Oct 2017 17:16:23 -0700 [thread overview]
Message-ID: <20171101001623.GE4911@magnolia> (raw)
In-Reply-To: <20171031232233.GI5858@dastard>
On Wed, Nov 01, 2017 at 10:22:33AM +1100, Dave Chinner wrote:
> On Tue, Oct 31, 2017 at 12:31:28PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Move the error injection tag names into a libxfs header so that we can
> > share it between kernel and userspace.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> Simple enough, but there's an admin problem with this patch.
>
> > new file mode 100644
> > index 0000000..0cc1c05
> > --- /dev/null
> > +++ b/fs/xfs/libxfs/xfs_errortag.h
> > @@ -0,0 +1,106 @@
> > +/*
> > + * Copyright (C) 2017 Oracle. All Rights Reserved.
> > + *
> > + * Author: Darrick J. Wong <darrick.wong@oracle.com>
>
> This isn't actually true. You're moving a bunch of code from
> fs/xfs/xfs_error.h that is under:
>
> * Copyright (c) 2000-2002,2005 Silicon Graphics, Inc.
> * All Rights Reserved.
>
> Moving code into a new file does not reassign the copyright on the
> code to a new owner. Hence I think this is the appropriate way to
> record the copyrights on this new file:
>
> * Copyright (c) 2000-2002,2005 Silicon Graphics, Inc.
> * Copyright (C) 2017 Oracle.
> * All Rights Reserved.
>
> And there's no real need for author tags as we've got that
> information in the git repo....
Works for me. I wasn't really sure whose copyright really applied to
changes like this -- the one in the source file? The person who creates
the new file? Every last person who ever touched it? etc.
They don't teach this stuff in maintainer school. :/
Will repost w/ revised copyright notice.
--D
>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-11-01 0:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 19:31 [PATCH] xfs: move error injection tags into their own file Darrick J. Wong
2017-10-31 23:22 ` Dave Chinner
2017-11-01 0:16 ` Darrick J. Wong [this message]
2017-11-01 0:53 ` Dave Chinner
2017-11-01 0:18 ` [PATCH v2] " Darrick J. Wong
2017-11-01 0:54 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171101001623.GE4911@magnolia \
--to=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.