From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [PATCH] drm/stm: checkpatch strict minor updates Date: Wed, 1 Nov 2017 09:33:01 -0200 Message-ID: <20171101113301.GD4111@jade> References: <1509013473-18365-1-git-send-email-philippe.cornu@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qk0-f196.google.com (mail-qk0-f196.google.com [209.85.220.196]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1A2766E710 for ; Wed, 1 Nov 2017 11:33:09 +0000 (UTC) Received: by mail-qk0-f196.google.com with SMTP id o187so2235118qke.7 for ; Wed, 01 Nov 2017 04:33:09 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1509013473-18365-1-git-send-email-philippe.cornu@st.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Philippe Cornu Cc: Maxime Coquelin , Alexandre Torgue , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Yannick Fertre , Fabien Dessenne , Mickael Reulier , Vincent Abriou , Gabriel Fernandez , Ludovic Barre List-Id: dri-devel@lists.freedesktop.org MjAxNy0xMC0yNiBQaGlsaXBwZSBDb3JudSA8cGhpbGlwcGUuY29ybnVAc3QuY29tPjoKCj4gTWlu b3IgZml4ZXMgZGV0ZWN0ZWQgd2l0aCAic2NyaXB0cy9jaGVja3BhdGNoLnBsIC0tc3RyaWN0Igo+ IAo+IFNpZ25lZC1vZmYtYnk6IFBoaWxpcHBlIENvcm51IDxwaGlsaXBwZS5jb3JudUBzdC5jb20+ Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9zdG0vZHdfbWlwaV9kc2ktc3RtLmMgfCA0ICsrLS0K PiAgZHJpdmVycy9ncHUvZHJtL3N0bS9sdGRjLmMgICAgICAgICAgICB8IDIgKy0KPiAgMiBmaWxl cyBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9zdG0vZHdfbWlwaV9kc2ktc3RtLmMgYi9kcml2ZXJzL2dwdS9k cm0vc3RtL2R3X21pcGlfZHNpLXN0bS5jCj4gaW5kZXggMTBiMmI3Ny4uM2U4YjllZCAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vc3RtL2R3X21pcGlfZHNpLXN0bS5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL3N0bS9kd19taXBpX2RzaS1zdG0uYwo+IEBAIC0xMjksNyArMTI5LDcgQEAg c3RhdGljIGludCBkc2lfcGxsX2dldF9wYXJhbXMoaW50IGNsa2luX2toeiwgaW50IGNsa291dF9r aHosCj4gIAlpbnQgZnZjb19taW4sIGZ2Y29fbWF4LCBkZWx0YSwgYmVzdF9kZWx0YTsgLyogYWxs IGluIGtoeiAqLwo+ICAKPiAgCS8qIEVhcmx5IGNoZWNrcyBwcmV2ZW50aW5nIGRpdmlzaW9uIGJ5 IDAgJiBvZGQgcmVzdWx0cyAqLwo+IC0JaWYgKChjbGtpbl9raHogPD0gMCkgfHwgKGNsa291dF9r aHogPD0gMCkpCj4gKwlpZiAoY2xraW5fa2h6IDw9IDAgfHwgY2xrb3V0X2toeiA8PSAwKQo+ICAJ CXJldHVybiAtRUlOVkFMOwo+ICAKPiAgCWZ2Y29fbWluID0gTEFORV9NSU5fS0JQUyAqIDIgKiBP REZfTUFYOwo+IEBAIC0xNTUsNyArMTU1LDcgQEAgc3RhdGljIGludCBkc2lfcGxsX2dldF9wYXJh bXMoaW50IGNsa2luX2toeiwgaW50IGNsa291dF9raHosCj4gIAkJZm9yIChvID0gT0RGX01JTjsg byA8PSBPREZfTUFYOyBvICo9IDIpIHsKPiAgCQkJbiA9IERJVl9ST1VORF9DTE9TRVNUKGkgKiBv ICogY2xrb3V0X2toeiwgY2xraW5fa2h6KTsKPiAgCQkJLyogQ2hlY2sgbmRpdiBhY2NvcmRpbmcg dG8gdmNvIHJhbmdlICovCj4gLQkJCWlmICgobiA8IG5fbWluKSB8fCAobiA+IG5fbWF4KSkKPiAr CQkJaWYgKG4gPCBuX21pbiB8fCBuID4gbl9tYXgpCj4gIAkJCQljb250aW51ZTsKPiAgCQkJLyog Q2hlY2sgaWYgbmV3IGRlbHRhIGlzIGJldHRlciAmIHNhdmVzIHBhcmFtZXRlcnMgKi8KPiAgCQkJ ZGVsdGEgPSBkc2lfcGxsX2dldF9jbGtvdXRfa2h6KGNsa2luX2toeiwgaSwgbiwgbykgLQo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vc3RtL2x0ZGMuYyBiL2RyaXZlcnMvZ3B1L2RybS9z dG0vbHRkYy5jCj4gaW5kZXggNzM1YzkwOC4uN2JlNjcxMCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vc3RtL2x0ZGMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9zdG0vbHRkYy5jCj4g QEAgLTU1Niw3ICs1NTYsNyBAQCBzdGF0aWMgaW50IGx0ZGNfcGxhbmVfYXRvbWljX2NoZWNrKHN0 cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+ICAJc3JjX2ggPSBzdGF0ZS0+c3JjX2ggPj4gMTY7Cj4g IAo+ICAJLyogUmVqZWN0IHNjYWxpbmcgKi8KPiAtCWlmICgoc3JjX3cgIT0gc3RhdGUtPmNydGNf dykgfHwgKHNyY19oICE9IHN0YXRlLT5jcnRjX2gpKSB7Cj4gKwlpZiAoc3JjX3cgIT0gc3RhdGUt PmNydGNfdyB8fCBzcmNfaCAhPSBzdGF0ZS0+Y3J0Y19oKSB7Cj4gIAkJRFJNX0VSUk9SKCJTY2Fs aW5nIGlzIG5vdCBzdXBwb3J0ZWQiKTsKPiAgCQlyZXR1cm4gLUVJTlZBTDsKClJldmlld2VkLWJ5 OiBHdXN0YXZvIFBhZG92YW4gPGd1c3Rhdm8ucGFkb3ZhbkBjb2xsYWJvcmEuY29tPgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754608AbdKALdS (ORCPT ); Wed, 1 Nov 2017 07:33:18 -0400 Received: from mail-qk0-f195.google.com ([209.85.220.195]:54838 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754564AbdKALdK (ORCPT ); Wed, 1 Nov 2017 07:33:10 -0400 X-Google-Smtp-Source: ABhQp+RAvQHxg2pC6IUT16u+mEjkNQiQpo+csEuOLmHhbNYoQoVBX0R/U2ur3No3VsClbiiHh6ZGUA== Date: Wed, 1 Nov 2017 09:33:01 -0200 From: Gustavo Padovan To: Philippe Cornu Cc: Yannick Fertre , Benjamin Gaignard , Vincent Abriou , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Alexandre Torgue , Fabien Dessenne , Maxime Coquelin , Mickael Reulier , Gabriel Fernandez , Ludovic Barre Subject: Re: [PATCH] drm/stm: checkpatch strict minor updates Message-ID: <20171101113301.GD4111@jade> References: <1509013473-18365-1-git-send-email-philippe.cornu@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1509013473-18365-1-git-send-email-philippe.cornu@st.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2017-10-26 Philippe Cornu : > Minor fixes detected with "scripts/checkpatch.pl --strict" > > Signed-off-by: Philippe Cornu > --- > drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 4 ++-- > drivers/gpu/drm/stm/ltdc.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c > index 10b2b77..3e8b9ed 100644 > --- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c > +++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c > @@ -129,7 +129,7 @@ static int dsi_pll_get_params(int clkin_khz, int clkout_khz, > int fvco_min, fvco_max, delta, best_delta; /* all in khz */ > > /* Early checks preventing division by 0 & odd results */ > - if ((clkin_khz <= 0) || (clkout_khz <= 0)) > + if (clkin_khz <= 0 || clkout_khz <= 0) > return -EINVAL; > > fvco_min = LANE_MIN_KBPS * 2 * ODF_MAX; > @@ -155,7 +155,7 @@ static int dsi_pll_get_params(int clkin_khz, int clkout_khz, > for (o = ODF_MIN; o <= ODF_MAX; o *= 2) { > n = DIV_ROUND_CLOSEST(i * o * clkout_khz, clkin_khz); > /* Check ndiv according to vco range */ > - if ((n < n_min) || (n > n_max)) > + if (n < n_min || n > n_max) > continue; > /* Check if new delta is better & saves parameters */ > delta = dsi_pll_get_clkout_khz(clkin_khz, i, n, o) - > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c > index 735c908..7be6710 100644 > --- a/drivers/gpu/drm/stm/ltdc.c > +++ b/drivers/gpu/drm/stm/ltdc.c > @@ -556,7 +556,7 @@ static int ltdc_plane_atomic_check(struct drm_plane *plane, > src_h = state->src_h >> 16; > > /* Reject scaling */ > - if ((src_w != state->crtc_w) || (src_h != state->crtc_h)) { > + if (src_w != state->crtc_w || src_h != state->crtc_h) { > DRM_ERROR("Scaling is not supported"); > return -EINVAL; Reviewed-by: Gustavo Padovan