Re: [PATCH] drm/vc4: Fix wrong printk format in vc4_bo_stats_debugfs()

From: Gustavo Padovan <gustavo@padovan.org>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org,
	Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] drm/vc4: Fix wrong printk format in vc4_bo_stats_debugfs()
Date: Wed, 1 Nov 2017 09:55:34 -0200	[thread overview]
Message-ID: <20171101115534.GE4111@jade> (raw)
In-Reply-To: <20171101095731.14878-1-boris.brezillon@free-electrons.com>

Hi Boris,

2017-11-01 Boris Brezillon <boris.brezillon@free-electrons.com>:

> vc4->purgeable.size and vc4->purgeable.purged_size are size_t fields
> and should be printed with a %zd specifier.
> 
> Fixes: b9f19259b84d ("drm/vc4: Add the DRM_IOCTL_VC4_GEM_MADVISE ioctl")
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
>  drivers/gpu/drm/vc4/vc4_bo.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_bo.c b/drivers/gpu/drm/vc4/vc4_bo.c
> index 3c3d11236910..4ae45d7dac42 100644
> --- a/drivers/gpu/drm/vc4/vc4_bo.c
> +++ b/drivers/gpu/drm/vc4/vc4_bo.c
> @@ -88,11 +88,11 @@ int vc4_bo_stats_debugfs(struct seq_file *m, void *unused)
>  
>  	mutex_lock(&vc4->purgeable.lock);
>  	if (vc4->purgeable.num)
> -		seq_printf(m, "%30s: %6dkb BOs (%d)\n", "userspace BO cache",
> +		seq_printf(m, "%30s: %6zdkb BOs (%d)\n", "userspace BO cache",
>  			   vc4->purgeable.size / 1024, vc4->purgeable.num);
>  
>  	if (vc4->purgeable.purged_num)
> -		seq_printf(m, "%30s: %6dkb BOs (%d)\n", "total purged BO",
> +		seq_printf(m, "%30s: %6zdkb BOs (%d)\n", "total purged BO",
>  			   vc4->purgeable.purged_size / 1024,
>  			   vc4->purgeable.purged_num);
>  	mutex_unlock(&vc4->purgeable.lock);

Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com>

Gustavo
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel