All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Egil Hjelmeland <privat@egil-hjelmeland.no>
Cc: vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 3/3] net: dsa: lan9303: lan9303_rcv set skb->offload_fwd_mark
Date: Wed, 1 Nov 2017 13:03:54 +0100	[thread overview]
Message-ID: <20171101120354.GA12680@lunn.ch> (raw)
In-Reply-To: <20171031144802.12686-4-privat@egil-hjelmeland.no>

> One exception: Because the ALR is set up to forward STP BPDUs only to CPU,
> the SW bridge should flood STP BPDUs if local STP is not enabled.
> This is archived by not setting skb->offload_fwd_mark on STP BPDUs.

Hi Egil

This bit is interesting. I had not thought about that.

I think we need a few more drivers to set offload_fwd_mark, and then
maybe try to consolidate it into the core. But it is too early now.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

  reply	other threads:[~2017-11-01 12:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-31 14:47 [PATCH net-next 0/3] net: dsa: lan9303: Fix STP and flooding issues Egil Hjelmeland
2017-10-31 14:48 ` [PATCH net-next 1/3] net: dsa: lan9303: Transmit using ALR when unicast Egil Hjelmeland
2017-11-01 12:04   ` Andrew Lunn
2017-10-31 14:48 ` [PATCH net-next 2/3] net: dsa: lan9303: Add STP ALR entry on port 0 Egil Hjelmeland
2017-11-01 12:04   ` Andrew Lunn
2017-10-31 14:48 ` [PATCH net-next 3/3] net: dsa: lan9303: lan9303_rcv set skb->offload_fwd_mark Egil Hjelmeland
2017-11-01 12:03   ` Andrew Lunn [this message]
2017-11-01 12:30 ` [PATCH net-next 0/3] net: dsa: lan9303: Fix STP and flooding issues David Miller
2017-11-02  9:06   ` Egil Hjelmeland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171101120354.GA12680@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=privat@egil-hjelmeland.no \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.