From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Re-enable fastboot by default
Date: Wed, 1 Nov 2017 17:06:43 +0200 [thread overview]
Message-ID: <20171101150643.GD10981@intel.com> (raw)
In-Reply-To: <20171101145325.3221-1-maarten.lankhorst@linux.intel.com>
On Wed, Nov 01, 2017 at 03:53:25PM +0100, Maarten Lankhorst wrote:
> This fix was originally reverted because it left a chromebook pixel
> black, and no immediate fix was available. This has been fixed in the
> meantime.
>
> Rather than trying to remove the parameter, set it to default to true
> for now, so we can always back out if required.
Like I said we have gaps in the state readout (eg. infoframes), so this
doesn't look entirely sane to me.
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Testcase: kms_panel_fitting
> ---
> drivers/gpu/drm/i915/i915_params.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
> index e54e6a4bc6bd..396126aac932 100644
> --- a/drivers/gpu/drm/i915/i915_params.h
> +++ b/drivers/gpu/drm/i915/i915_params.h
> @@ -57,7 +57,7 @@
> param(bool, alpha_support, IS_ENABLED(CONFIG_DRM_I915_ALPHA_SUPPORT)) \
> param(bool, enable_cmd_parser, true) \
> param(bool, enable_hangcheck, true) \
> - param(bool, fastboot, false) \
> + param(bool, fastboot, true) \
> param(bool, prefault_disable, false) \
> param(bool, load_detect_test, false) \
> param(bool, force_reset_modeset_test, false) \
> --
> 2.14.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-11-01 15:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 14:53 [PATCH] drm/i915: Re-enable fastboot by default Maarten Lankhorst
2017-11-01 15:06 ` Ville Syrjälä [this message]
2017-11-01 15:13 ` Ville Syrjälä
2017-11-01 16:04 ` ✗ Fi.CI.BAT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171101150643.GD10981@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.