From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH rdma-next v1 1/6] IB/uverbs: Allow CQ moderation with modify CQ Date: Wed, 1 Nov 2017 12:06:16 -0600 Message-ID: <20171101180616.GI1030@ziepe.ca> References: <20171029182808.GN16127@mtr-leonro.local> <20171030144807.GA12392@ziepe.ca> <20171030152815.GA16127@mtr-leonro.local> <20171030155236.GC12392@ziepe.ca> <20171030190952.GC16127@mtr-leonro.local> <20171030230753.GB4081@ziepe.ca> <20171031050802.GE16127@mtr-leonro.local> <13d687d9-80b4-621e-87bf-c6045da98c0c@dev.mellanox.co.il> <20171031154046.GB9852@ziepe.ca> <6e7e94e2-9b50-bfa4-a06a-b2452e1bc8a5@dev.mellanox.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <6e7e94e2-9b50-bfa4-a06a-b2452e1bc8a5-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Yishai Hadas Cc: Leon Romanovsky , Doug Ledford , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Yonatan Cohen , Yishai Hadas , Majd Dibbiny List-Id: linux-rdma@vger.kernel.org On Tue, Oct 31, 2017 at 07:06:05PM +0200, Yishai Hadas wrote: > The above argument could be issued also on SRQ/WQ which are not expected to > be changed in a high rate but uses the attr_mask notation with one system > call. Yep, those perhaps should not have used the attr_mask scheme either > As this is currently the spirit of modify_xxx verbs in both user and kernel, > we may stay with that and consider this change for verbs2.0 all around when > it will come. Well, there seem to be quite a lot of new API proposals now, and stuffing each of them through some goofy comp_mask or attr_mask thing seems like it is going to create a huge complex mess.. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html