All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Disseldorp <ddiss@suse.de>
To: Ilya Dryomov <idryomov@gmail.com>
Cc: Ceph Development <ceph-devel@vger.kernel.org>,
	Mike Christie <mchristi@redhat.com>
Subject: Re: [PATCH] rbd: set discard alignment to zero
Date: Thu, 2 Nov 2017 00:43:38 +0100	[thread overview]
Message-ID: <20171102004338.39d87dea@suse.de> (raw)
In-Reply-To: <CAOi1vP_Qt4NMG+8Hi_He6PBiCoJgfg6JBL53Ty=iJtmSRF4cTA@mail.gmail.com>

Thanks for the feedback, Ilya.

On Wed, 1 Nov 2017 18:14:04 +0100, Ilya Dryomov wrote:

> Yeah, discard_alignment == discard_granularity seems bogus.  The name
> is misleading too, but that probably comes from SBC, which talks about
> OPTIMAL UNMAP GRANULARITY and UNMAP GRANULARITY ALIGNMENT.
> 
> 0 is the default -- let's just drop discard_alignment assignment?

Works for me, if you'd prefer. I'll send through a v2 with this.

> Also, you quoted <disk>/<partition>/discard_alignment description, but
> this is about <disk>/discard_alignment.  This had me confused for
> a moment.

Oops, my bad. Will use the <disk> only description in the next round.

Cheers, David

  reply	other threads:[~2017-11-01 23:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-01 12:24 [PATCH] rbd: set discard alignment to zero David Disseldorp
2017-11-01 17:14 ` Ilya Dryomov
2017-11-01 23:43   ` David Disseldorp [this message]
2017-11-02  0:05     ` [PATCH v2] " David Disseldorp
2017-11-02  8:53       ` Ilya Dryomov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171102004338.39d87dea@suse.de \
    --to=ddiss@suse.de \
    --cc=ceph-devel@vger.kernel.org \
    --cc=idryomov@gmail.com \
    --cc=mchristi@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.