All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Mark Brown <broonie@kernel.org>
Cc: Laura Abbott <labbott@redhat.com>,
	Benjamin Gaignard <benjamin.gaignard@linaro.org>,
	sumit.semwal@linaro.org, arve@android.com, riandrews@android.com,
	dan.carpenter@oracle.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-api@vger.kernel.org
Subject: Re: [PATCH v6 2/2] staging: ion: create one device entry per heap
Date: Thu, 2 Nov 2017 11:44:07 +0100	[thread overview]
Message-ID: <20171102104407.GA14048@kroah.com> (raw)
In-Reply-To: <20171031191153.avolosp6n5gb3xao@sirena.co.uk>

On Tue, Oct 31, 2017 at 07:11:53PM +0000, Mark Brown wrote:
> On Tue, Oct 31, 2017 at 12:03:35PM -0700, Laura Abbott wrote:
> 
> > I'm not a fan of the platform bus but I have mixed feelings about
> > creating a dedicated bus type. I guess if we really need a bus
> > type we can do it later?
> 
> There was a discussion a while ago in the context of I2C/SPI MFDs
> which concluded that if you need a bus and it's going to be effectively
> noop then you should just use the platform bus as anything else will
> consist almost entirely of cut'n'paste from the platform bus with some
> light sed usage and code duplication is bad.  It's not super lovely as
> it's not actually a memory mapped device but it's the best idea we've
> got.

Ugh, I hate that.  What's wrong with using a "virtual" device instead?

I can create a "virtual" bus for things like this if they really want a
"simple" bus, abusing platform for this is the major reason I hate the
platform bus code...

thanks,

greg k-h

  parent reply	other threads:[~2017-11-02 10:44 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-23 15:55 [PATCH v6 0/2] staging: ion: get one device per heap Benjamin Gaignard
2017-10-23 15:55 ` Benjamin Gaignard
2017-10-23 15:55 ` [PATCH v6 1/2] staging: ion: simplify ioctl args checking function Benjamin Gaignard
2017-10-23 15:55   ` Benjamin Gaignard
2017-10-23 15:55 ` [PATCH v6 2/2] staging: ion: create one device entry per heap Benjamin Gaignard
2017-10-23 15:55   ` Benjamin Gaignard
2017-10-24 16:14   ` Jordan Crouse
2017-10-31 19:03   ` Laura Abbott
2017-10-31 19:03     ` Laura Abbott
     [not found]     ` <3e3af8e3-76c5-754c-caaa-3f8c9b54723f-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-10-31 19:11       ` Mark Brown
2017-10-31 19:11         ` Mark Brown
2017-10-31 19:45         ` Laura Abbott
2017-10-31 19:45           ` Laura Abbott
2017-11-02 10:44         ` Greg KH [this message]
2017-11-02 11:10           ` Mark Brown
2017-11-02 11:10             ` Mark Brown
2017-11-06 14:42             ` Benjamin Gaignard
2017-11-06 14:42               ` Benjamin Gaignard
     [not found]               ` <CA+M3ks5pV=j_DeQ9ohhtv62WL=pzWH0Q5jdKtQby5vs=NUZT-Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-06 14:46                 ` Greg KH
2017-11-06 14:46                   ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2017-11-06 15:59 [PATCH v6 0/2] staging: ion: get one device " Benjamin Gaignard
2017-11-06 15:59 ` [PATCH v6 2/2] staging: ion: create one device entry " Benjamin Gaignard
2017-11-09 21:17   ` Laura Abbott
2017-11-09 21:17     ` Laura Abbott
2017-11-27 10:46     ` Benjamin Gaignard
2017-11-27 10:46       ` Benjamin Gaignard
     [not found]       ` <CA+M3ks6vP+W77QBzbczxzcV7YZCoBusC=wgjZPUNLrCYFFDARA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-27 11:43         ` Greg Kroah-Hartman
2017-11-27 11:43           ` Greg Kroah-Hartman
2017-11-27 16:12           ` Daniel Vetter
2017-11-27 16:12             ` Daniel Vetter
2017-11-27 16:30             ` Mark Brown
2017-11-28 13:32   ` Greg KH
2017-11-28 13:32     ` Greg KH
     [not found]     ` <20171128133217.GA29995-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-11-28 16:26       ` Mark Brown
2017-11-28 16:26         ` Mark Brown
2017-11-28 17:08         ` Greg KH
2017-11-28 17:08           ` Greg KH
2017-11-28 17:12           ` Mark Brown
2017-11-28 17:12             ` Mark Brown
2017-11-28 17:28             ` Greg KH
2017-11-28 17:28               ` Greg KH
2017-11-28 17:37               ` Mark Brown
2017-11-28 17:37                 ` Mark Brown
2017-11-28 18:00                 ` Greg KH
2017-11-28 18:00                   ` Greg KH
2017-11-29 14:00     ` Benjamin Gaignard
2017-11-29 14:00       ` Benjamin Gaignard
2017-12-02 15:53       ` Greg KH
2017-12-02 15:53         ` Greg KH
     [not found]         ` <20171202155317.GB5311-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-12-05 23:01           ` Laura Abbott
2017-12-05 23:01             ` Laura Abbott
     [not found]             ` <65ef83b2-db3e-eaf6-129f-40e156400624-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-12-06  6:28               ` Greg KH
2017-12-06  6:28                 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171102104407.GA14048@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arve@android.com \
    --cc=benjamin.gaignard@linaro.org \
    --cc=broonie@kernel.org \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=labbott@redhat.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=riandrews@android.com \
    --cc=sumit.semwal@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.