From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH] drm/i915: silence coverity warning
Date: Thu, 2 Nov 2017 15:22:51 +0200 [thread overview]
Message-ID: <20171102132251.GM10981@intel.com> (raw)
In-Reply-To: <150962438796.6111.14920303375315314711@mail.alporthouse.com>
On Thu, Nov 02, 2017 at 12:06:27PM +0000, Chris Wilson wrote:
> Quoting Lionel Landwerlin (2017-11-02 11:41:26)
> > Because dev_priv is 0-ed it's not currently an issue, but since we
> > have dev_priv->perf.oa.test_config.uuid size at uuid + 1, we could
> > just copy the null character and silence this warning.
>
> It doesn't copy the nul over exactly, to be complete s/strncpy/strlcpy/
> as well.
Or just memcpy(), thugh maybe that'd be more dangerous if the size
gets changed for some reasonn.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-11-02 13:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 11:41 [PATCH] drm/i915: silence coverity warning Lionel Landwerlin
2017-11-02 12:06 ` Chris Wilson
2017-11-02 13:22 ` Ville Syrjälä [this message]
2017-11-02 13:38 ` Chris Wilson
2017-11-02 12:18 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-11-02 13:11 ` ✗ Fi.CI.IGT: warning " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171102132251.GM10981@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.