All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	Philippe Ombredanne <pombredanne@nexb.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] License cleanup: add SPDX license identifiers to some kernel files
Date: Thu, 2 Nov 2017 19:02:02 +0100	[thread overview]
Message-ID: <20171102180202.GA30563@kroah.com> (raw)
In-Reply-To: <CA+55aFyph4523x7f9UmNUfPOxQ8keGCCjnTWa2JHUhr24X9M2g@mail.gmail.com>

On Thu, Nov 02, 2017 at 10:52:23AM -0700, Linus Torvalds wrote:
> On Thu, Nov 2, 2017 at 10:45 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > For .h files, we had to use /* */
> 
> That should only be true for the uapi files (because they may
> encounter old compilers), not for *.h files in general, I feel.

Oh I wish that were the case :(

Thomas and I fought with the vdso build logic[1], and some other
arch-specific stuff for a good day trying to track down all of the
individual .h files that were getting pulled in by gcc to spit out a .S
file.  We eventually just gave up trying to fix them all up one by one,
the combinations were just too large.  By using /* */ for all .h files,
all build combinations worked just fine automatically, no special-casing
needed.

That was _just_ with the first patch in the series applied, no UAPI file
modifications at all.  Our build system is crazy...

thanks,

greg k-h

[1] I found a bug where if any vdso.S files fail to build, the build
    system keeps on going just fine.  Still can't figure out how to fix
    that, obviously it's not something that ever usually happens.  I now
    know why anyone who ever touches those files are driven to drink...

  reply	other threads:[~2017-11-02 18:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-02 15:16 [GIT PULL] License cleanup: add SPDX license identifiers to some kernel files Greg KH
2017-11-02 17:09 ` Masahiro Yamada
2017-11-02 17:25   ` Linus Torvalds
2017-11-02 17:32     ` Linus Torvalds
2017-11-02 17:45       ` Greg KH
2017-11-02 17:52         ` Linus Torvalds
2017-11-02 18:02           ` Greg KH [this message]
2017-11-02 18:18             ` Linus Torvalds
2017-11-02 18:21               ` Thomas Gleixner
2017-11-02 18:53                 ` Linus Torvalds
2017-11-02 17:25   ` Greg KH
2017-11-08 23:07 ` Rob Herring
2017-11-09 13:40   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171102180202.GA30563@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pombredanne@nexb.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.