All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/gdb: ARC version has stringent dependencies on host gcc
Date: Thu, 2 Nov 2017 22:44:26 +0100	[thread overview]
Message-ID: <20171102224426.1900f2d5@windsurf> (raw)
In-Reply-To: <20171102181405.6476-1-yann.morin.1998@free.fr>

Hello,

On Thu,  2 Nov 2017 19:14:05 +0100, Yann E. MORIN wrote:
> The ARC gdb version requires a gcc >= 4.8 (because C++11).
> 
> Since the host variant uses the same sources as the target variant, we
> must ensure that we have a host gcc >= 4.8 as well.
> 
> Move the architecture dependencies to their own symbol, and also hide
> the comment when they are not met.
> 
> Fixes:
>     http://autobuild.buildroot.net/results/43eae264991aa369490236c7bd59c0b6a67fcf25/
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  package/gdb/Config.in.host | 18 ++++++++++++++----
>  1 file changed, 14 insertions(+), 4 deletions(-)

Applied to master, thanks.

However, there are still a few cases that are not taken into account:

 * We need C++ support in the toolchain to build the target gdb for
   ARC. This is already handled for !ARC, because BR2_GDB_VERSION_8_0
   can only be selected if BR2_INSTALL_LIBSTDCPP=y.

   Note: I'm not sure if we need C++ to build just gdbserver, it would
   be worth checking. Currently, for gdb 8.x, we require C++, even if
   the user only wants gdbserver on the target.

 * We need a 4.8 target compiler to build the target gdb for ARC.
   Indeed, a user might enable BR2_PACKAGE_GDB on ARC to build the
   target gdb. And that would fail if the compiler isn't gcc >= 4.8.
   I'm not even sure ARC ever had a toolchain using gcc 4.8, but in
   theory this dependency is missing.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2017-11-02 21:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-02 18:14 [Buildroot] [PATCH] package/gdb: ARC version has stringent dependencies on host gcc Yann E. MORIN
2017-11-02 21:12 ` Thomas Petazzoni
2017-11-02 21:25   ` Yann E. MORIN
2017-11-02 21:31     ` Thomas Petazzoni
2017-11-02 21:31 ` Alexey Brodkin
2017-11-02 21:37   ` Thomas Petazzoni
2017-11-02 21:38   ` Yann E. MORIN
2017-11-02 21:41     ` Alexey Brodkin
2017-11-02 21:44 ` Thomas Petazzoni [this message]
2017-11-02 22:07   ` Alexey Brodkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171102224426.1900f2d5@windsurf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.