From: Darren Hart <dvhart@infradead.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Souvik Kumar Chakravarty <souvik.k.chakravarty@intel.com>,
Andy Shevchenko <andy@infradead.org>,
Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>,
Shanth Murthy <shanth.murthy@intel.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: intel_telemetry: add back linux/io.h inclusion
Date: Thu, 2 Nov 2017 18:01:58 -0700 [thread overview]
Message-ID: <20171103010158.GC7971@fury> (raw)
In-Reply-To: <20171102164933.110292-1-arnd@arndb.de>
On Thu, Nov 02, 2017 at 05:49:27PM +0100, Arnd Bergmann wrote:
> This one wasn't redundant after all, as shown by this randconfig
> build error:
>
> drivers/platform/x86/intel_telemetry_pltdrv.c: In function 'telem_evtlog_read':
> drivers/platform/x86/intel_telemetry_pltdrv.c:900:20: error: implicit declaration of function 'readq' [-Werror=implicit-function-declaration]
>
> We should generally include exactly the set of headers that declare
> the interfaces we use, so this adds back the missing include to
> get it to compile again.
Thanks Arnd, Andy already caught this and has it queued.
--
Darren Hart
VMware Open Source Technology Center
prev parent reply other threads:[~2017-11-03 1:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 16:49 [PATCH] platform/x86: intel_telemetry: add back linux/io.h inclusion Arnd Bergmann
2017-11-03 1:01 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171103010158.GC7971@fury \
--to=dvhart@infradead.org \
--cc=andy@infradead.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rajneesh.bhardwaj@intel.com \
--cc=shanth.murthy@intel.com \
--cc=souvik.k.chakravarty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.