From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Norris Subject: Re: [PATCH v2 1/2] HID: i2c-hid: add reset gpio property Date: Fri, 3 Nov 2017 19:29:35 -0700 Message-ID: <20171104022934.GA110548@google.com> References: <1509418996-25348-1-git-send-email-hl@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1509418996-25348-1-git-send-email-hl-TNX95d0MmH7DzftRWevZcw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lin Huang Cc: dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, jikos-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, benjamin.tissoires-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-input@vger.kernel.org On Tue, Oct 31, 2017 at 11:03:15AM +0800, Lin Huang wrote: > some i2c hid devices have reset gpio, need to control > it in the driver. > > Signed-off-by: Lin Huang > --- > Changes in v2: > - Add 10us in usleep_range() upper range > - reuse post_power_delay_ms as deassert reset delay > - delete deassert_reset_us property > > drivers/hid/i2c-hid/i2c-hid.c | 61 +++++++++++++++++++++++++++-------- > include/linux/platform_data/i2c-hid.h | 3 ++ > 2 files changed, 50 insertions(+), 14 deletions(-) Reviewed-by: Brian Norris -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755255AbdKDC3l (ORCPT ); Fri, 3 Nov 2017 22:29:41 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:44042 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751869AbdKDC3j (ORCPT ); Fri, 3 Nov 2017 22:29:39 -0400 X-Google-Smtp-Source: ABhQp+QQnnAbiI2KoGYxo2lWLDdPFxLIC2xweg2I7rOwk/1N4B5TqA8h+QgYt4D4noFhvjyc2CDIuA== Date: Fri, 3 Nov 2017 19:29:35 -0700 From: Brian Norris To: Lin Huang Cc: dmitry.torokhov@gmail.com, jikos@kernel.org, robh@kernel.org, benjamin.tissoires@redhat.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 1/2] HID: i2c-hid: add reset gpio property Message-ID: <20171104022934.GA110548@google.com> References: <1509418996-25348-1-git-send-email-hl@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1509418996-25348-1-git-send-email-hl@rock-chips.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 31, 2017 at 11:03:15AM +0800, Lin Huang wrote: > some i2c hid devices have reset gpio, need to control > it in the driver. > > Signed-off-by: Lin Huang > --- > Changes in v2: > - Add 10us in usleep_range() upper range > - reuse post_power_delay_ms as deassert reset delay > - delete deassert_reset_us property > > drivers/hid/i2c-hid/i2c-hid.c | 61 +++++++++++++++++++++++++++-------- > include/linux/platform_data/i2c-hid.h | 3 ++ > 2 files changed, 50 insertions(+), 14 deletions(-) Reviewed-by: Brian Norris