From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [patch v11 1/4] drivers: jtag: Add JTAG core driver Date: Sat, 4 Nov 2017 12:36:32 +0100 Message-ID: <20171104113632.GC24583@kroah.com> References: <1509724449-26221-1-git-send-email-oleksandrs@mellanox.com> <1509724449-26221-2-git-send-email-oleksandrs@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1509724449-26221-2-git-send-email-oleksandrs-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Oleksandr Shamray Cc: arnd-r2nGTMty4D4@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, openbmc-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org, jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org, tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org, linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mec-WqBc5aa1uDFeoWH0uzbU5w@public.gmane.org, vadimp-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, system-sw-low-level-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, openocd-devel-owner-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, mchehab-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Jiri Pirko List-Id: linux-api@vger.kernel.org On Fri, Nov 03, 2017 at 05:54:06PM +0200, Oleksandr Shamray wrote: > diff --git a/include/uapi/linux/jtag.h b/include/uapi/linux/jtag.h > new file mode 100644 > index 0000000..0b25a83 > --- /dev/null > +++ b/include/uapi/linux/jtag.h > @@ -0,0 +1,117 @@ > +/* > + * JTAG class driver > + * > + * Copyright (c) 2017 Mellanox Technologies. All rights reserved. > + * Copyright (c) 2017 Oleksandr Shamray > + * > + * Released under the GPLv2/BSD. > + * SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause Minor nit, this should go on the first line of the .h file now, to match the rest of the kernel (just happened, not your fault.) Also, uapi files are not just GPLv2, they have the userspace exception, so this should just be: SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note no need to add any BSD stuff to it at all. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=linuxfoundation.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=gregkh@linuxfoundation.org; receiver=) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3yTcGb0jKwzDrCZ for ; Sat, 4 Nov 2017 22:36:22 +1100 (AEDT) Received: from localhost (LFbn-1-12253-150.w90-92.abo.wanadoo.fr [90.92.67.150]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 1A914504; Sat, 4 Nov 2017 11:36:19 +0000 (UTC) Date: Sat, 4 Nov 2017 12:36:32 +0100 From: Greg KH To: Oleksandr Shamray Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, openbmc@lists.ozlabs.org, joel@jms.id.au, jiri@resnulli.us, tklauser@distanz.ch, linux-serial@vger.kernel.org, mec@shout.net, vadimp@mellanox.com, system-sw-low-level@mellanox.com, robh+dt@kernel.org, openocd-devel-owner@lists.sourceforge.net, linux-api@vger.kernel.org, davem@davemloft.net, mchehab@kernel.org, Jiri Pirko Subject: Re: [patch v11 1/4] drivers: jtag: Add JTAG core driver Message-ID: <20171104113632.GC24583@kroah.com> References: <1509724449-26221-1-git-send-email-oleksandrs@mellanox.com> <1509724449-26221-2-git-send-email-oleksandrs@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1509724449-26221-2-git-send-email-oleksandrs@mellanox.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Nov 2017 11:36:23 -0000 On Fri, Nov 03, 2017 at 05:54:06PM +0200, Oleksandr Shamray wrote: > diff --git a/include/uapi/linux/jtag.h b/include/uapi/linux/jtag.h > new file mode 100644 > index 0000000..0b25a83 > --- /dev/null > +++ b/include/uapi/linux/jtag.h > @@ -0,0 +1,117 @@ > +/* > + * JTAG class driver > + * > + * Copyright (c) 2017 Mellanox Technologies. All rights reserved. > + * Copyright (c) 2017 Oleksandr Shamray > + * > + * Released under the GPLv2/BSD. > + * SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause Minor nit, this should go on the first line of the .h file now, to match the rest of the kernel (just happened, not your fault.) Also, uapi files are not just GPLv2, they have the userspace exception, so this should just be: SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note no need to add any BSD stuff to it at all. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh@linuxfoundation.org (Greg KH) Date: Sat, 4 Nov 2017 12:36:32 +0100 Subject: [patch v11 1/4] drivers: jtag: Add JTAG core driver In-Reply-To: <1509724449-26221-2-git-send-email-oleksandrs@mellanox.com> References: <1509724449-26221-1-git-send-email-oleksandrs@mellanox.com> <1509724449-26221-2-git-send-email-oleksandrs@mellanox.com> Message-ID: <20171104113632.GC24583@kroah.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Nov 03, 2017 at 05:54:06PM +0200, Oleksandr Shamray wrote: > diff --git a/include/uapi/linux/jtag.h b/include/uapi/linux/jtag.h > new file mode 100644 > index 0000000..0b25a83 > --- /dev/null > +++ b/include/uapi/linux/jtag.h > @@ -0,0 +1,117 @@ > +/* > + * JTAG class driver > + * > + * Copyright (c) 2017 Mellanox Technologies. All rights reserved. > + * Copyright (c) 2017 Oleksandr Shamray > + * > + * Released under the GPLv2/BSD. > + * SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause Minor nit, this should go on the first line of the .h file now, to match the rest of the kernel (just happened, not your fault.) Also, uapi files are not just GPLv2, they have the userspace exception, so this should just be: SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note no need to add any BSD stuff to it at all. thanks, greg k-h