From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yann E. MORIN Date: Sun, 5 Nov 2017 14:31:45 +0100 Subject: [Buildroot] [PATCH v4 1/1] package/libssh2: Add selectable crypto libraries In-Reply-To: <6626fb96-a677-2bbe-d801-7352cc4c6428@mind.be> References: <1509553376-43168-1-git-send-email-sam.voss@rockwellcollins.com> <9271f8cc-651b-e302-f82c-9e44a0af24d4@mind.be> <87tvy92lyy.fsf@dell.be.48ers.dk> <20171105081900.GC2996@scaer> <87lgjl2el7.fsf@dell.be.48ers.dk> <6626fb96-a677-2bbe-d801-7352cc4c6428@mind.be> Message-ID: <20171105133145.GJ2996@scaer> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Arnout, All, On 2017-11-05 13:46 +0100, Arnout Vandecappelle spake thusly: > On 05-11-17 11:40, Peter Korsgaard wrote: > >>>>>> "Yann" == Yann E MORIN writes: > > >> > This does affect people updating Buildroot, so it needs to be mentioned in CHANGES. > > >> > > >> Why don't we just keep the old logic instead? E.G. leave the select > > >> openssl if !(mbedtls || libgcrypt) and then change the selects to > > >> depends on in the choice: > > >> > > >> choice > > >> > > >> config BR2_PACKAGE_LIBSSH2_MBEDTLS > > >> bool "mbedtls" > > >> depends on BR2_PACKAGE_MBEDTLS > > >> > > >> ... > > >> > > >> Doesn't that give us the best of both worlds? Same behaviour as before > > >> by default and still the option to explicitly chose when multiple > > >> backends are available? > > > > > That's what Sam did in the initial iterations of his patchset, but > > > Arnout and Thomas (IIRC) both requested he replaces that with a select > > > instead. > > > > Hmm, I could only find Arnouts mail asking to use select, but he didn't > > write why. Arnout, why not use depends on here? > > I was just applying the default principle that you should use select rather > than depends unless there is a good reason to use depends. I hadn't thought of > backward compatibility back then, and I didn't think of using depends now. > > I've already committed, can you fix it up? I think that using select is better, so we should keep it as-is, even though that means backward incompatibility. After all, a user should review their configuration pon updating Buildroot. Note: this exposes a flaw in the way we handle legacy: it can only take care of options that were removed, and can not account for new options like this case. There is nothing we can do about this, though... :-/ Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'