From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] suport/download: force svn to be non-interactive
Date: Sun, 5 Nov 2017 16:14:49 +0100 [thread overview]
Message-ID: <20171105161449.2774486a@windsurf.home> (raw)
In-Reply-To: <5c06394b-324c-f7fe-77b5-53fc7eeedc76@dawncrow.de>
Hello,
On Sun, 5 Nov 2017 15:46:14 +0100, Andr? Hentschel wrote:
> Am 03.11.2017 um 22:22 schrieb Yann E. MORIN:
> > Fixes:
> > http://autobuild.buildroot.org/results/2af/2af7412846c576089f8596857ab8c81ac31c1bed/
> >
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > Cc: Andr? Hentschel <nerv@dawncrow.de>
> > ---
> > support/download/svn | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/support/download/svn b/support/download/svn
> > index 77abf3d02d..9f27d71f86 100755
> > --- a/support/download/svn
> > +++ b/support/download/svn
> > @@ -33,6 +33,6 @@ _svn() {
> > eval ${SVN} "${@}"
> > }
> >
> > -_svn export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
> > +_svn --non-interactive export ${verbose} "${@}" "'${repo}@${rev}'" "'${basename}'"
> >
> > tar czf "${output}" "${basename}"
> >
>
>
> Signed-off-by: Andr? Hentschel <nerv@dawncrow.de>
Such a Signed-off-by doesn't make sense, because you're not passing
the code to someone else. You probably wanted to give one (or several)
of the following:
- Reviewed-by:
- Tested-by:
- Acked-by:
See the manual for the detailed definition of those tags.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-11-05 15:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 21:22 [Buildroot] [PATCH] suport/download: force svn to be non-interactive Yann E. MORIN
2017-11-05 14:46 ` André Hentschel
2017-11-05 14:50 ` Arnout Vandecappelle
2017-11-05 14:54 ` Yann E. MORIN
2017-11-05 15:14 ` Thomas Petazzoni [this message]
2017-11-05 15:14 ` André Hentschel
2017-11-05 16:34 ` Arnout Vandecappelle
2017-11-05 16:40 ` Yann E. MORIN
2017-11-05 16:41 ` Yann E. MORIN
2017-11-05 20:17 ` Peter Korsgaard
2017-11-26 21:01 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171105161449.2774486a@windsurf.home \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.