From: Steffen Klassert <steffen.klassert@secunet.com>
To: Florian Westphal <fw@strlen.de>
Cc: <netdev@vger.kernel.org>
Subject: Re: [PATCH ipsec-next] xfrm: don't pull esp/auth header in xfrm_parse_spi
Date: Mon, 6 Nov 2017 10:38:03 +0100 [thread overview]
Message-ID: <20171106093803.GF23855@secunet.com> (raw)
In-Reply-To: <20171102125410.20203-1-fw@strlen.de>
On Thu, Nov 02, 2017 at 01:54:10PM +0100, Florian Westphal wrote:
> syzbot reported an issue where pointer to ip header content was not
> reloaded after xfrm_parse_spi().
>
> Its not intuitive that this function changes skb->head, so switch to
> skb_pointer_header.
I have to admit that this is not intuitive, but we pull
these headers later anyway. So using skb_header_pointer()
here might add another memcpy that could be avoided.
I think I'll stay with the fix you submitted for the ipsec
tree already.
prev parent reply other threads:[~2017-11-06 9:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 12:54 [PATCH ipsec-next] xfrm: don't pull esp/auth header in xfrm_parse_spi Florian Westphal
2017-11-06 9:38 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171106093803.GF23855@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.