From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] ethtool: Allow enabling/disabling pretty printing
Date: Mon, 6 Nov 2017 10:19:38 +0100 [thread overview]
Message-ID: <20171106101938.327397d6@windsurf.home> (raw)
In-Reply-To: <20171106090757.kekhjjkecm3ck3e3@sapphire.tkos.co.il>
Hello,
On Mon, 6 Nov 2017 11:07:57 +0200, Baruch Siach wrote:
> On Mon, Nov 06, 2017 at 10:05:35AM +0100, Thomas Petazzoni wrote:
> > On Mon, 06 Nov 2017 09:52:37 +0100, Peter Korsgaard wrote:
> >
> > > > +if BR2_PACKAGE_ETHTOOL
> > > > +
> > > > + config BR2_PACKAGE_ETHTOOL_PRETTY_PRINT
> > > > + bool "enable pretty printing"
> > > > + default y
> >
> > Should this really be "default y" ? Baruch reported a significant size
> > increase with this option enabled.
>
> This is the current default. The added option only allows to to remove pretty
> printing.
Aah, ok. Works for me then.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2017-11-06 9:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 1:29 [Buildroot] [PATCH] ethtool: Allow enabling/disabling pretty printing Florian Fainelli
2017-11-06 5:30 ` Baruch Siach
2017-11-06 5:36 ` Florian Fainelli
2017-11-06 8:52 ` Peter Korsgaard
2017-11-06 9:05 ` Thomas Petazzoni
2017-11-06 9:07 ` Baruch Siach
2017-11-06 9:19 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171106101938.327397d6@windsurf.home \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.