From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 6 Nov 2017 14:50:02 +0100 From: Pablo Neira Ayuso Message-ID: <20171106135002.GA7055@salvia> References: <20171016102402.10358-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171016102402.10358-1-colin.king@canonical.com> Subject: Re: [Bridge] [PATCH] netfilter: ebtables: clean up initialization of buf List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Colin King Cc: kernel-janitors@vger.kernel.org, netdev@vger.kernel.org, bridge@lists.linux-foundation.org, Florian Westphal , linux-kernel@vger.kernel.org, coreteam@netfilter.org, netfilter-devel@vger.kernel.org, Jozsef Kadlecsik , "David S . Miller" On Mon, Oct 16, 2017 at 11:24:02AM +0100, Colin King wrote: > From: Colin Ian King > > buf is initialized to buf_start and then set on the next statement > to buf_start + offsets[i]. Clean this up to just initialize buf > to buf_start + offsets[i] to clean up the clang build warning: > "Value stored to 'buf' during its initialization is never read" Applied, thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Date: Mon, 06 Nov 2017 13:50:02 +0000 Subject: Re: [PATCH] netfilter: ebtables: clean up initialization of buf Message-Id: <20171106135002.GA7055@salvia> List-Id: References: <20171016102402.10358-1-colin.king@canonical.com> In-Reply-To: <20171016102402.10358-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: Jozsef Kadlecsik , Florian Westphal , Stephen Hemminger , "David S . Miller" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, bridge@lists.linux-foundation.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On Mon, Oct 16, 2017 at 11:24:02AM +0100, Colin King wrote: > From: Colin Ian King > > buf is initialized to buf_start and then set on the next statement > to buf_start + offsets[i]. Clean this up to just initialize buf > to buf_start + offsets[i] to clean up the clang build warning: > "Value stored to 'buf' during its initialization is never read" Applied, thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH] netfilter: ebtables: clean up initialization of buf Date: Mon, 6 Nov 2017 14:50:02 +0100 Message-ID: <20171106135002.GA7055@salvia> References: <20171016102402.10358-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jozsef Kadlecsik , Florian Westphal , Stephen Hemminger , "David S . Miller" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, bridge@lists.linux-foundation.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org To: Colin King Return-path: Content-Disposition: inline In-Reply-To: <20171016102402.10358-1-colin.king@canonical.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netfilter-devel.vger.kernel.org On Mon, Oct 16, 2017 at 11:24:02AM +0100, Colin King wrote: > From: Colin Ian King > > buf is initialized to buf_start and then set on the next statement > to buf_start + offsets[i]. Clean this up to just initialize buf > to buf_start + offsets[i] to clean up the clang build warning: > "Value stored to 'buf' during its initialization is never read" Applied, thanks.