From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next v2] net: mvpp2: add ethtool GOP statistics
Date: Mon, 6 Nov 2017 15:25:34 +0100
Message-ID: <20171106142534.GC24822@lunn.ch>
References: <20171103110425.16097-1-miquel.raynal@free-electrons.com>
 <20171103151906.GQ24320@lunn.ch>
 <20171106110653.034009ad@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "David S . Miller" <davem@davemloft.net>,
        Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
        Antoine Tenart <antoine.tenart@free-electrons.com>,
        Gregory Clement <gregory.clement@free-electrons.com>,
        Nadav Haklai <nadavh@marvell.com>, netdev@vger.kernel.org,
        Stefan Chulski <stefanc@marvell.com>,
        Florian Fainelli <f.fainelli@gmail.com>
To: Miquel RAYNAL <miquel.raynal@free-electrons.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:44443 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752829AbdKFOZk (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 6 Nov 2017 09:25:40 -0500
Content-Disposition: inline
In-Reply-To: <20171106110653.034009ad@xps13>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

> Here I do have a problem: I choose the IDA solution because it was
> quite straightforward but I agree it would be better to use an unique
> name. Unfortunately, on the Armada-8040-DB that instantiate this driver
> twice, the node name is not unique. There are two CP (master and
> slave) and both names are "ethernet@0". Otherwise, if I use the full
> path, I get something like
> "/cp110-master/config-space@f2000000/ethernet@0" and
> "/cp110-slave/config-space@f4000000/ethernet@0" but the problem is that
> workqueue names are truncated to 24 characters and only 15 appears in
> ps, so it would not solve the issue and choosing the "parent
> parent node name" would work here but does not scale very well. Do you
> have any idea to get this right?

Hi Miquel

You could move the starting of the thread into mvpp2_port_probe(). If
you do it after register_netdev(dev), you can use netdev_name(dev).

    Andrew