Re: [Qemu-devel] Make 9pfs buildable for Windows

[Greg Kurz <groug@kaod.org>]

On Fri, 29 Sep 2017 13:13:05 +0200
Michael Fritscher <michael@fritscher.net> wrote:

> Good day,
> 

Hi,

Sorry for the late reply... Since I have only limited bandwidth, I'll only
be able to provide some limited feedback.

A global remark to start with: it is a usual practice to prefix each patch
title with the component's name, as explained here:

https://wiki.qemu.org/Contribute/SubmitAPatch#Write_a_meaningful_commit_message

eg, patch titles in this series should start with something like with fsdev: or
9pfs: or oslib-win32:

> this is the patch series to make 9pfs buildable (not working!) on Windows.
> It is compiling and starts, but obvousily 9pfs is not working - in fact it
> spits out a initializing error.
> 

What's the error message ?

> Next step: Implement the directory and file handling stuff.
> 
> Quoting myself:
> 
> "
> The biggest issue seems to be the *at stuff. I'll
> try to workaround this via getting the directories' path from the file
> descriptor with the /proc (as it is already done in the 9pfs_utils) -
> luckily,the mingw environment emulates the /proc. If this doesn't work
> I've another idea (the file descriptors needs to be "registered" with the
> path (and saved in a sparse vector or map with the fd as key and the path
> as value). The "big" solution would be to write a 9p_local_windows.c from
> scratch, but I would like to avoid it.
> "
> 
> I know that some people want to have compiling and working together, but I
> hope(!) that I get a first working version next week.
> 

Any updates ? Not sure people will spend time reviewing this series until
something actually works.

> Best regards,
> Michael Fritscher
> 

Cheers,

--
Greg

PS: if you repost, please use my maintainer's email address groug@kaod.org