From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
To: Selvin Xavier <selvin.xavier@broadcom.com>,
Devesh Sharma <devesh.sharma@broadcom.com>,
Doug Ledford <dledford@redhat.com>
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Subject: [PATCH] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey
Date: Mon, 6 Nov 2017 08:35:14 -0600 [thread overview]
Message-ID: <20171106143514.GA19786@embeddedor.com> (raw)
Check on return value and goto label mbx_err are unnecessary.
Addresses-Coverity-ID: 1268780
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
index f8c14c7..db02bbb 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
@@ -1956,9 +1956,7 @@ int ocrdma_mbx_dealloc_lkey(struct ocrdma_dev *dev, int fr_mr, u32 lkey)
cmd->lkey = lkey;
cmd->rsvd_frmr = fr_mr ? 1 : 0;
status = ocrdma_mbx_cmd(dev, (struct ocrdma_mqe *)cmd);
- if (status)
- goto mbx_err;
-mbx_err:
+
kfree(cmd);
return status;
}
--
2.7.4
next reply other threads:[~2017-11-06 14:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 14:35 Gustavo A. R. Silva [this message]
[not found] ` <20171106143514.GA19786-L1vi/lXTdts+Va1GwOuvDg@public.gmane.org>
2017-11-07 6:31 ` [PATCH] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey Yuval Shaia
2017-11-07 6:31 ` Yuval Shaia
2017-11-07 14:27 ` Gustavo A. R. Silva
2017-11-07 8:25 ` Leon Romanovsky
2017-11-07 8:25 ` Leon Romanovsky
2017-11-07 14:30 ` Gustavo A. R. Silva
[not found] ` <20171107083022.Horde.E7wKXkvErbmdKSHiwomsj7N-fU+oOHjIBR1LoJgMfuPDHBfZZeVsHd8q@public.gmane.org>
2017-11-07 14:44 ` Leon Romanovsky
2017-11-07 14:44 ` Leon Romanovsky
2017-11-07 14:45 ` [PATCH v2] " Gustavo A. R. Silva
2017-11-07 14:50 ` Leon Romanovsky
2017-11-07 14:56 ` Gustavo A. R. Silva
[not found] ` <20171107085637.Horde.qFzN3uJQkHeQUTyEgZzV4mv-fU+oOHjIBR1LoJgMfuPDHBfZZeVsHd8q@public.gmane.org>
2017-11-07 16:28 ` Leon Romanovsky
2017-11-07 16:28 ` Leon Romanovsky
[not found] ` <20171107162804.GM18825-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-11-08 20:16 ` Gustavo A. R. Silva
2017-11-08 20:16 ` Gustavo A. R. Silva
2017-11-09 8:28 ` Leon Romanovsky
[not found] ` <20171107144517.GA25631-L1vi/lXTdts+Va1GwOuvDg@public.gmane.org>
2017-11-13 21:19 ` Doug Ledford
2017-11-13 21:19 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171106143514.GA19786@embeddedor.com \
--to=garsilva@embeddedor.com \
--cc=devesh.sharma@broadcom.com \
--cc=dledford@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=selvin.xavier@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.