From: Tejun Heo <tj@kernel.org>
To: Paolo Valente <paolo.valente@linaro.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block <linux-block@vger.kernel.org>,
Luca Miccio <lucmiccio@gmail.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Mark Brown <broonie@kernel.org>,
dhowells@redhat.com, hpa@zytor.com, akinobu.mita@gmail.com
Subject: Re: high overhead of functions blkg_*stats_* in bfq
Date: Mon, 6 Nov 2017 08:30:40 -0800 [thread overview]
Message-ID: <20171106163040.GC3252168@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <A4406E55-0956-4A8C-B14D-B95E8743D399@linaro.org>
Hello,
On Mon, Nov 06, 2017 at 05:26:38PM +0100, Paolo Valente wrote:
> Yes. DEBUG_BLK_CGROUP will just serve to keep the for-debugging
> subset switched off even when the dynamic parameter is on.
>
> We'll wait for possible counter-arguments from Tejun, and then start
> to work on what you propose.
So, I think the only *really* required ones are io_serviced and the
corresponding byte counts, which are tracked by blk-cgroup core
anyway. Everything else can be hidden behind an obviously debug boot
param, say, bfq.__DEBUG__extra_stats or whatever.
Thanks.
--
tejun
next prev parent reply other threads:[~2017-11-06 16:30 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 10:11 high overhead of functions blkg_*stats_* in bfq Paolo Valente
2017-10-17 12:45 ` Paolo Valente
2017-10-17 16:45 ` Linus Walleij
2017-10-17 16:49 ` Jens Axboe
2017-10-18 13:19 ` Tejun Heo
2017-10-18 14:45 ` Jens Axboe
2017-10-18 15:05 ` Paolo Valente
2017-10-18 15:44 ` Jens Axboe
[not found] ` <2B52CB68-213C-470F-945C-0ADFF9AA7A66@linaro.org>
2017-10-18 15:08 ` Paolo Valente
2017-10-18 15:40 ` Paolo Valente
[not found] ` <D6586934-DF02-4102-8839-8912DFA86BB0@linaro.org>
2017-10-19 6:50 ` Paolo Valente
2017-10-21 16:13 ` Tejun Heo
2017-10-22 8:25 ` Paolo Valente
2017-10-30 9:49 ` David Howells
2017-11-05 7:39 ` Paolo Valente
2017-11-06 2:21 ` Jens Axboe
2017-11-06 9:22 ` Ulf Hansson
2017-11-06 9:49 ` Paolo Valente
2017-11-06 10:48 ` Ulf Hansson
2017-11-06 11:20 ` Paolo Valente
2017-11-06 15:00 ` Tejun Heo
2017-11-06 15:47 ` Paolo Valente
2017-11-06 16:11 ` Paolo Valente
2017-11-06 16:13 ` Jens Axboe
2017-11-06 16:21 ` Paolo Valente
2017-11-06 16:22 ` Jens Axboe
2017-11-06 16:26 ` Paolo Valente
2017-11-06 16:30 ` Tejun Heo [this message]
2017-11-06 16:33 ` Paolo Valente
2017-11-06 16:37 ` Tejun Heo
2017-11-06 16:39 ` Jens Axboe
2017-11-06 17:05 ` Paolo Valente
2017-11-06 16:03 ` Jens Axboe
2017-11-06 16:10 ` Paolo Valente
2017-11-06 18:46 ` Paolo Valente
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171106163040.GC3252168@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=akinobu.mita@gmail.com \
--cc=axboe@kernel.dk \
--cc=broonie@kernel.org \
--cc=dhowells@redhat.com \
--cc=hpa@zytor.com \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=lucmiccio@gmail.com \
--cc=paolo.valente@linaro.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.