From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] vboot-utils issue in Buildroot
Date: Mon, 6 Nov 2017 20:48:08 +0100 [thread overview]
Message-ID: <20171106204808.52b09e63@windsurf> (raw)
In-Reply-To: <20171106184840.GA28366@latitude.localdomain>
Hello,
Thanks for your feedback. However, please keep the mailing list in Cc.
Thanks!
On Mon, 6 Nov 2017 20:48:40 +0200, Alex Suykov wrote:
> > Could you have a look at what this architecture specific code is doing?
> > It's somewhat weird in a set of host utilities to have something that
> > would depend on the target architecture.
>
> Those are target-specific definitions for sure, so ARCH must
> be the target architecture there. I'll try to send a patch now.
Gentoo defines ARCH == HOST_ARCH. Be careful that if they are
different, vboot-utils will try to use Qemu.
> vboot-utils aren't really host-only, it's also a target package in ChromeOS
> and it fills the role of efibootmgr on PC. The code in crossystem_arch
> seems to be about boot configuration, so completely irrelevant when building
> a host package. But it always gets built.
>
> Chromeos does support cross-compiling, but I suspect no-one ever tried
> building it on a host that wasn't x86_64 or maybe arm.
But it's quite weird to have a dependency on the target architecture
when building a host tool. Looking at the ARM specific code for
example, it pokes into /proc/firmware/device-tree/, which obviously has
no chance to exist on the build machine.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-11-06 19:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 16:24 [Buildroot] vboot-utils issue in Buildroot Thomas Petazzoni
[not found] ` <20171106184840.GA28366@latitude.localdomain>
2017-11-06 19:48 ` Thomas Petazzoni [this message]
2017-11-06 21:15 ` Alex Suykov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171106204808.52b09e63@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.