From: Andi Kleen <ak@linux.intel.com>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, acme@redhat.com,
peterz@infradead.org, mingo@elte.hu, kan.liang@intel.com,
jolsa@redhat.com
Subject: Re: [PATCH v2 4/5] perf/record: add support for sampling skid ip
Date: Mon, 6 Nov 2017 13:25:19 -0800 [thread overview]
Message-ID: <20171106212519.GC5320@tassilo.jf.intel.com> (raw)
In-Reply-To: <1509646559-919-5-git-send-email-eranian@google.com>
On Thu, Nov 02, 2017 at 11:15:58AM -0700, Stephane Eranian wrote:
> This patch adds a new --skid-ip option to perf record
> to capture the unmodified interrupted instruction pointer in
> each sample. With this option, the kernel captures both the
> ip and skid ip. Unless precise mode is enabled both ip are
> the same. They may be different in precise mode depending
> on the event and precise sampling mode.
>
> $ perf record --skid-ip .....
perf record already has too many options. I would rather just make it a
event qualifier which is more flexible too
perf record -e cpu/cpu-cycles,skidip=1/
-Andi
next prev parent reply other threads:[~2017-11-06 21:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 18:15 [PATCH v2 0/5] perf: add support for capturing skid IP Stephane Eranian
2017-11-02 18:15 ` [PATCH v2 1/5] perf/core: add PERF_RECORD_SAMPLE_SKID_IP record type Stephane Eranian
2017-11-02 18:59 ` Peter Zijlstra
2017-11-02 19:46 ` Stephane Eranian
2017-11-02 18:15 ` [PATCH v2 2/5] perf/x86: add PERF_SAMPLE_SKID_IP support for X86 PEBS Stephane Eranian
2017-11-03 15:05 ` Jiri Olsa
2017-11-02 18:15 ` [PATCH v2 3/5] perf/tools: add support for PERF_SAMPLE_SKID_IP Stephane Eranian
2017-11-02 18:15 ` [PATCH v2 4/5] perf/record: add support for sampling skid ip Stephane Eranian
2017-11-06 21:25 ` Andi Kleen [this message]
2017-11-02 18:15 ` [PATCH v2 5/5] perf/script: add support for " Stephane Eranian
2017-11-03 15:03 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171106212519.GC5320@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.