All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: "Aurélien Chabot" <aurelien@chabot.fr>
Cc: wireguard@lists.zx2c4.com
Subject: Re: [PATCH 1/4] Add wireguard-go as submodule
Date: Tue, 7 Nov 2017 10:34:46 +0100	[thread overview]
Message-ID: <20171107093446.GA7891@kroah.com> (raw)
In-Reply-To: <20171107043817.9050-2-aurelien@chabot.fr>

On Tue, Nov 07, 2017 at 03:38:12PM +1100, Aurélien Chabot wrote:
> Signed-off-by: Aurélien Chabot <aurelien@chabot.fr>
> ---
>  .gitmodules  | 3 +++
>  wireguard-go | 1 +
>  2 files changed, 4 insertions(+)
>  create mode 100644 .gitmodules
>  create mode 160000 wireguard-go
> 
> diff --git a/.gitmodules b/.gitmodules
> new file mode 100644
> index 0000000..c7957ea
> --- /dev/null
> +++ b/.gitmodules
> @@ -0,0 +1,3 @@
> +[submodule "wireguard-go"]
> +	path = wireguard-go
> +	url = git@github.com:trishika/wireguard-go.git

Ugh, submodules are a pain in git, do you really want to do it this way?
If so, why?  I thought there was a "replacement" for submodules that was
recommended to use instead.

And I mention this because I have a submodule in a project I maintain,
and I _always_ mess it up when I go to update it, and have to go read
the documentation for how to do it properly.

thanks,

greg k-h

  reply	other threads:[~2017-11-07  9:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-07  4:38 WireGuard root-less support for android Aurélien Chabot
2017-11-07  4:38 ` [PATCH 1/4] Add wireguard-go as submodule Aurélien Chabot
2017-11-07  9:34   ` Greg KH [this message]
2017-11-07  9:53     ` Jason A. Donenfeld
2017-11-07  4:38 ` [PATCH 2/4] Add support for android in wireguard-go Aurélien Chabot
2017-11-07  4:38 ` [PATCH 3/4] Add support of wireguard-go as an Android Vpn Service Aurélien Chabot
2017-11-07  4:38 ` [PATCH 4/4] Add build instruction Aurélien Chabot
2017-11-07  4:38 ` [PATCH 1/2] Put the code in a 'wireguard' go package Aurélien Chabot
2017-11-07  4:38 ` [PATCH 2/2] Add android support Aurélien Chabot
2017-11-07  9:57 ` WireGuard root-less support for android Jason A. Donenfeld
2017-11-08  5:15 ` Samuel Holland
2017-11-08 17:44 ` Mathias Hall-Andersen
2017-11-08 21:50   ` Aurélien Chabot
2018-01-23  1:52     ` Aurélien Chabot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171107093446.GA7891@kroah.com \
    --to=greg@kroah.com \
    --cc=aurelien@chabot.fr \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.