From: Cornelia Huck <cohuck@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
david@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 1/2] qdev_monitor: Simplify error handling in qdev_device_add()
Date: Tue, 7 Nov 2017 15:01:43 +0100 [thread overview]
Message-ID: <20171107150143.182ce22f.cohuck@redhat.com> (raw)
In-Reply-To: <1509617407-21191-2-git-send-email-thuth@redhat.com>
On Thu, 2 Nov 2017 11:10:05 +0100
Thomas Huth <thuth@redhat.com> wrote:
> Instead of doing the clean-ups on errors multiple times, introduce
> a jump label at the end of the function that can be used by all
> error paths that need this cleanup.
>
> Suggested-by: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> qdev-monitor.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2017-11-07 14:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 10:10 [Qemu-devel] [PATCH for-2.11 v3 0/2] Check for the availability of a hotplug controller before adding a device Thomas Huth
2017-11-02 10:10 ` [Qemu-devel] [PATCH v3 1/2] qdev_monitor: Simplify error handling in qdev_device_add() Thomas Huth
2017-11-07 14:01 ` Cornelia Huck [this message]
2017-11-02 10:10 ` [Qemu-devel] [PATCH v3 2/2] qdev: Check for the availability of a hotplug controller before adding a device Thomas Huth
2017-11-07 14:17 ` Cornelia Huck
2017-11-13 14:00 ` Markus Armbruster
2017-11-13 14:12 ` Thomas Huth
2017-12-18 11:59 ` [Qemu-devel] [PATCH for-2.11 v3 0/2] " Thomas Huth
2018-01-09 20:09 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171107150143.182ce22f.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=armbru@redhat.com \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.