From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH 1/1] nvme/fc: add 'discovery' sysfs attribute to fc transport device
Date: Tue, 7 Nov 2017 11:25:28 -0800 [thread overview]
Message-ID: <20171107192528.GC13618@infradead.org> (raw)
In-Reply-To: <1509722369-95879-2-git-send-email-hare@suse.de>
> + list_for_each_entry(lport, &nvme_fc_lport_list, port_list) {
> + list_for_each_entry_safe(rport, tmp_rport,
> + &lport->endp_list, endp_list) {
> + if (!nvme_fc_rport_get(rport))
> + continue;
> + spin_unlock_irqrestore(&nvme_fc_lock, flags);
> + nvme_fc_signal_discovery_scan(lport, rport);
> + nvme_fc_rport_put(rport);
> + spin_lock_irqsave(&nvme_fc_lock, flags);
> + }
> + }
> + spin_unlock_irqrestore(&nvme_fc_lock, flags);
What guarantees the list next pointers are still valid after
you dropped nvme_fc_lock?
next prev parent reply other threads:[~2017-11-07 19:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 15:19 [PATCH 0/1] NVMe-FC autoconnect, second try Hannes Reinecke
2017-11-03 15:19 ` [PATCH 1/1] nvme/fc: add 'discovery' sysfs attribute to fc transport device Hannes Reinecke
2017-11-03 17:16 ` James Smart
2017-11-07 19:25 ` Christoph Hellwig [this message]
2017-11-08 16:31 ` Hannes Reinecke
2017-11-08 18:16 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171107192528.GC13618@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.