From: Jiri Olsa <jolsa@redhat.com>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, acme@redhat.com,
peterz@infradead.org, mingo@elte.hu, ak@linux.intel.com,
kan.liang@intel.com
Subject: Re: [PATCH v3 5/5] perf/script: add support for skid ip
Date: Wed, 8 Nov 2017 11:43:37 +0100 [thread overview]
Message-ID: <20171108104337.GA1629@krava> (raw)
In-Reply-To: <1510127797-22483-6-git-send-email-eranian@google.com>
On Tue, Nov 07, 2017 at 11:56:37PM -0800, Stephane Eranian wrote:
SNIP
> diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> index 223165055d41..ee8fb635f694 100644
> --- a/tools/perf/util/session.c
> +++ b/tools/perf/util/session.c
> @@ -1133,7 +1133,7 @@ static void dump_sample(struct perf_evsel *evsel, union perf_event *event,
> sample_read__printf(sample, evsel->attr.read_format);
>
> if (sample_type & PERF_SAMPLE_SKID_IP)
> - printf("... skid_ip: %" PRIu64 "\n", sample->skid_ip);
> + printf("... skid_ip: 0x%" PRIx64 "\n", sample->skid_ip);
should be part of the patch 3/5
jirka
prev parent reply other threads:[~2017-11-08 10:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 7:56 [PATCH v3 0/5] perf: add support for capturing skid IP Stephane Eranian
2017-11-08 7:56 ` [PATCH v3 1/5] perf/core: add PERF_RECORD_SAMPLE_SKID_IP record type Stephane Eranian
2017-11-08 7:56 ` [PATCH v3 2/5] perf/x86: add PERF_SAMPLE_SKID_IP support for X86 PEBS Stephane Eranian
2017-11-08 7:56 ` [PATCH v3 3/5] perf/tools: add support for PERF_SAMPLE_SKID_IP Stephane Eranian
2017-11-08 7:56 ` [PATCH v3 4/5] perf/record: add documentation for sampling skid ip Stephane Eranian
2017-11-08 20:56 ` Andi Kleen
2017-11-09 3:42 ` Stephane Eranian
2017-11-08 7:56 ` [PATCH v3 5/5] perf/script: add support for " Stephane Eranian
2017-11-08 10:43 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171108104337.GA1629@krava \
--to=jolsa@redhat.com \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.