From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lelnx193.ext.ti.com (lelnx193.ext.ti.com [198.47.27.77]) by arago-project.org (Postfix) with ESMTPS id 7A94852A42 for ; Wed, 8 Nov 2017 14:45:20 +0000 (UTC) Received: from dflxv15.itg.ti.com ([128.247.5.124]) by lelnx193.ext.ti.com (8.15.1/8.15.1) with ESMTP id vA8EjKTt007521 for ; Wed, 8 Nov 2017 08:45:20 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1510152320; bh=ZuhuXckfHTnm/yM7/p1d2QFKknKg1cJH5y3gw4Lht/c=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=b8vIoOoWz7xKcKU1XKhxZTgLzicPNmbqKu0G7WuQ9ynqMvs322QwySBZG9z/BCxMO sPHiD4qBHynzoqqY5dP+XBBtdztwghR2p104WM8nb1NFt0PL8Bi20LWXN1tawSDsk0 mk3MluOLFa1I82COV6YThbcm2dc/XqoiNt4T+KSk= Received: from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id vA8EjKQJ006257 for ; Wed, 8 Nov 2017 08:45:20 -0600 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34; Wed, 8 Nov 2017 08:45:19 -0600 Received: from dlep32.itg.ti.com (157.170.170.100) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend Transport; Wed, 8 Nov 2017 08:45:19 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id vA8EjJCC029797; Wed, 8 Nov 2017 08:45:20 -0600 Date: Wed, 8 Nov 2017 09:45:04 -0500 From: Denys Dmytriyenko To: Karthik Ramanan Message-ID: <20171108144504.GA12918@edge> References: <1510112505-15937-1-git-send-email-x0038811@ti.com> <4913a363-0e3b-8a93-88e3-d7187a795a2f@ti.com> MIME-Version: 1.0 In-Reply-To: <4913a363-0e3b-8a93-88e3-d7187a795a2f@ti.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Cc: meta-arago@arago-project.org, Ramprasad N Subject: Re: [morty PATCH] gstreamer1.0*-good: Increase v4l2src minimum buffers by 4 X-BeenThere: meta-arago@arago-project.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Arago metadata layer for TI SDKs - OE-Core/Yocto compatible List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Nov 2017 14:45:21 -0000 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Wed, Nov 08, 2017 at 05:36:33PM +0800, Karthik Ramanan wrote: > Looks good. ACK. Where's the patch? > On 08-Nov-17 11:41 AM, Ramprasad N wrote: > >Signed-off-by: Ramprasad N > >--- > > ...v4l2src-Increase-minimum-num-buffers-by-4.patch | 33 ++++++++++++++++++++++ > > .../gstreamer1.0-plugins-good_1.8.3.bbappend | 8 ++++++ > > 2 files changed, 41 insertions(+) > > create mode 100644 meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good/0001-v4l2src-Increase-minimum-num-buffers-by-4.patch > > create mode 100644 meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.8.3.bbappend > > > >diff --git a/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good/0001-v4l2src-Increase-minimum-num-buffers-by-4.patch b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good/0001-v4l2src-Increase-minimum-num-buffers-by-4.patch > >new file mode 100644 > >index 0000000..1af90c1 > >--- /dev/null > >+++ b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good/0001-v4l2src-Increase-minimum-num-buffers-by-4.patch > >@@ -0,0 +1,33 @@ > >+From 73254df370fec6a2eb1ae6711955307a1d4bf173 Mon Sep 17 00:00:00 2001 > >+From: Ramprasad N > >+Date: Fri, 13 Oct 2017 15:48:06 +0530 > >+Subject: [PATCH] v4l2src: Increase minimum num buffers by 4 > >+ > >+v4l2src plugin allocates 4 buffers for the pipeline. > >+To capture video in realtime the pipeline without frameloss, > >+four buffers are not sufficient. Increase the > >+number of buffers by 4 more. > >+ > >+Signed-off-by: Ramprasad N > >+--- > >+ sys/v4l2/gstv4l2object.c | 4 +++- > >+ 1 file changed, 3 insertions(+), 1 deletion(-) > >+ > >+diff --git a/sys/v4l2/gstv4l2object.c b/sys/v4l2/gstv4l2object.c > >+index 549e06f..773f46d 100644 > >+--- a/sys/v4l2/gstv4l2object.c > >++++ b/sys/v4l2/gstv4l2object.c > >+@@ -3939,7 +3939,9 @@ gst_v4l2_object_decide_allocation (GstV4l2Object * obj, GstQuery * query) > >+ * to fill the pipeline, the minimum required to decoder according to the > >+ * driver and 1 more, so we don't endup up with everything downstream or > >+ * held by the decoder. */ > >+- own_min = min + obj->min_buffers + 1; > >++ /* Increase the number of buffers required by 4 more to capture video in > >++ * realtime. With default number of 4 buffers, frame loss is observed */ > >++ own_min = min + obj->min_buffers + 5; > >+ > >+ /* If no allocation parameters where provided, allow for a little more > >+ * buffers and enable copy threshold */ > >+-- > >+1.9.1 > >+ > >diff --git a/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.8.3.bbappend b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.8.3.bbappend > >new file mode 100644 > >index 0000000..29a07b2 > >--- /dev/null > >+++ b/meta-arago-extras/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.8.3.bbappend > >@@ -0,0 +1,8 @@ > >+PR_append = ".arago0" > >+ > >+FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" > >+ > >+SRC_URI += " \ > >+ file://0001-v4l2src-Increase-minimum-num-buffers-by-4.patch \ > >+ " > >+ > > _______________________________________________ > meta-arago mailing list > meta-arago@arago-project.org > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago