From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41251) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCUPc-0005f9-S1 for qemu-devel@nongnu.org; Wed, 08 Nov 2017 12:45:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCUPY-0004mI-JI for qemu-devel@nongnu.org; Wed, 08 Nov 2017 12:45:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:22978) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eCUPY-0004lv-Dj for qemu-devel@nongnu.org; Wed, 08 Nov 2017 12:45:12 -0500 Date: Wed, 8 Nov 2017 17:45:06 +0000 From: "Daniel P. Berrange" Message-ID: <20171108174506.GI12670@redhat.com> Reply-To: "Daniel P. Berrange" References: <20171107104653.8913-1-paul.durrant@citrix.com> <20171108174227.GC8403@stefanha-x1.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20171108174227.GC8403@stefanha-x1.localdomain> Subject: Re: [Qemu-devel] [PATCH v3] xen-disk: use an IOThread per instance List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Paul Durrant , Kevin Wolf , Stefano Stabellini , qemu-devel@nongnu.org, Max Reitz , Anthony Perard , xen-devel@lists.xenproject.org On Wed, Nov 08, 2017 at 05:42:27PM +0000, Stefan Hajnoczi wrote: > On Tue, Nov 07, 2017 at 05:46:53AM -0500, Paul Durrant wrote: > > This patch allocates an IOThread object for each xen_disk instance and > > sets the AIO context appropriately on connect. This allows processing > > of I/O to proceed in parallel. > > > > The patch also adds tracepoints into xen_disk to make it possible to > > follow the state transtions of an instance in the log. > > virtio-blk and virtio-scsi allow the user to specify an IOThread object. > This allows users to configure the device<->IOThread mapping any way > they like (e.g. 1:1, M:N). Are you sure you want to hard-code the > IOThread mapping? I certainly think it'd be better for mgmt apps if all disks had the same approach to IOThread mapping. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] [PATCH v3] xen-disk: use an IOThread per instance Date: Wed, 8 Nov 2017 17:45:06 +0000 Message-ID: <20171108174506.GI12670@redhat.com> References: <20171107104653.8913-1-paul.durrant@citrix.com> <20171108174227.GC8403@stefanha-x1.localdomain> Reply-To: "Daniel P. Berrange" Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCUPa-0001C6-Cm for xen-devel@lists.xenproject.org; Wed, 08 Nov 2017 17:45:14 +0000 Content-Disposition: inline In-Reply-To: <20171108174227.GC8403@stefanha-x1.localdomain> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Stefan Hajnoczi Cc: Kevin Wolf , Stefano Stabellini , qemu-devel@nongnu.org, Max Reitz , Paul Durrant , Anthony Perard , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org T24gV2VkLCBOb3YgMDgsIDIwMTcgYXQgMDU6NDI6MjdQTSArMDAwMCwgU3RlZmFuIEhham5vY3pp IHdyb3RlOgo+IE9uIFR1ZSwgTm92IDA3LCAyMDE3IGF0IDA1OjQ2OjUzQU0gLTA1MDAsIFBhdWwg RHVycmFudCB3cm90ZToKPiA+IFRoaXMgcGF0Y2ggYWxsb2NhdGVzIGFuIElPVGhyZWFkIG9iamVj dCBmb3IgZWFjaCB4ZW5fZGlzayBpbnN0YW5jZSBhbmQKPiA+IHNldHMgdGhlIEFJTyBjb250ZXh0 IGFwcHJvcHJpYXRlbHkgb24gY29ubmVjdC4gVGhpcyBhbGxvd3MgcHJvY2Vzc2luZwo+ID4gb2Yg SS9PIHRvIHByb2NlZWQgaW4gcGFyYWxsZWwuCj4gPiAKPiA+IFRoZSBwYXRjaCBhbHNvIGFkZHMg dHJhY2Vwb2ludHMgaW50byB4ZW5fZGlzayB0byBtYWtlIGl0IHBvc3NpYmxlIHRvCj4gPiBmb2xs b3cgdGhlIHN0YXRlIHRyYW5zdGlvbnMgb2YgYW4gaW5zdGFuY2UgaW4gdGhlIGxvZy4KPiAKPiB2 aXJ0aW8tYmxrIGFuZCB2aXJ0aW8tc2NzaSBhbGxvdyB0aGUgdXNlciB0byBzcGVjaWZ5IGFuIElP VGhyZWFkIG9iamVjdC4KPiBUaGlzIGFsbG93cyB1c2VycyB0byBjb25maWd1cmUgdGhlIGRldmlj ZTwtPklPVGhyZWFkIG1hcHBpbmcgYW55IHdheQo+IHRoZXkgbGlrZSAoZS5nLiAxOjEsIE06Tiku ICBBcmUgeW91IHN1cmUgeW91IHdhbnQgdG8gaGFyZC1jb2RlIHRoZQo+IElPVGhyZWFkIG1hcHBp bmc/CgpJIGNlcnRhaW5seSB0aGluayBpdCdkIGJlIGJldHRlciBmb3IgbWdtdCBhcHBzIGlmIGFs bCBkaXNrcyBoYWQgdGhlIHNhbWUKYXBwcm9hY2ggdG8gSU9UaHJlYWQgbWFwcGluZy4KClJlZ2Fy ZHMsCkRhbmllbAotLSAKfDogaHR0cHM6Ly9iZXJyYW5nZS5jb20gICAgICAtby0gICAgaHR0cHM6 Ly93d3cuZmxpY2tyLmNvbS9waG90b3MvZGJlcnJhbmdlIDp8Cnw6IGh0dHBzOi8vbGlidmlydC5v cmcgICAgICAgICAtby0gICAgICAgICAgICBodHRwczovL2ZzdG9wMTM4LmJlcnJhbmdlLmNvbSA6 fAp8OiBodHRwczovL2VudGFuZ2xlLXBob3RvLm9yZyAgICAtby0gICAgaHR0cHM6Ly93d3cuaW5z dGFncmFtLmNvbS9kYmVycmFuZ2UgOnwKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhl bi5vcmcKaHR0cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=