All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Abderrahmane Benbachir <abderrahmane.benbachir@polymtl.ca>,
	linux-kernel@vger.kernel.org, mingo@redhat.com,
	mathieu.desnoyers@efficios.com,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC PATCH v2] ftrace: support very early function tracing
Date: Wed, 8 Nov 2017 20:07:27 +0100	[thread overview]
Message-ID: <20171108190727.GL3326@worktop> (raw)
In-Reply-To: <20171108110757.5ef58e53@gandalf.local.home>

On Wed, Nov 08, 2017 at 11:07:57AM -0500, Steven Rostedt wrote:
> On Wed, 8 Nov 2017 09:10:58 +0100
> Peter Zijlstra <peterz@infradead.org> wrote:
> 
> > On Tue, Nov 07, 2017 at 09:17:06PM -0500, Steven Rostedt wrote:
> > > > +#ifdef CONFIG_X86_TSC
> > > > +	entry->clock = rdtsc();
> > > > +#else
> > > > +	entry->clock = trace_clock_local();
> > > > +#endif  
> > 
> > > > +#ifdef CONFIG_X86_TSC
> > > > +	cpu_khz = native_calibrate_cpu();
> > > > +#endif  
> > 
> > > > +#ifdef CONFIG_X86_TSC
> > > > +		ns = cycles_to_ns(entry->clock, cpu_khz);
> > > > +#else
> > > > +		ns = entry->clock;
> > > > +#endif  
> > 
> > Yeah, no, not going to happen...
> 
> Agreed.

Depends on how early you need things; ideally you'd be able to use the
stuff from here:

  https://lkml.kernel.org/r/1504116205-355281-1-git-send-email-pasha.tatashin@oracle.com

That is, fix the normal time sources to work earlier instead of building
parallel infrastructure.

  reply	other threads:[~2017-11-08 19:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-07 23:44 [RFC PATCH v2] ftrace: support very early function tracing Abderrahmane Benbachir
2017-11-08  2:17 ` Steven Rostedt
2017-11-08  8:10   ` Peter Zijlstra
2017-11-08 16:07     ` Steven Rostedt
2017-11-08 19:07       ` Peter Zijlstra [this message]
2017-11-08 19:19         ` Steven Rostedt
2017-11-08 19:33           ` Peter Zijlstra
2017-11-08 15:56   ` Abderrahmane Benbachir
2017-11-08 18:44     ` Abderrahmane Benbachir
2017-11-08 19:09       ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171108190727.GL3326@worktop \
    --to=peterz@infradead.org \
    --cc=abderrahmane.benbachir@polymtl.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.