From: David Disseldorp <ddiss@suse.de>
To: Ilya Dryomov <idryomov@gmail.com>
Cc: Ceph Development <ceph-devel@vger.kernel.org>
Subject: Re: [PATCH 2/2] rbd: get rid of rbd_mapping::read_only
Date: Wed, 8 Nov 2017 19:32:42 +0100 [thread overview]
Message-ID: <20171108193242.7b3b16c5@suse.de> (raw)
In-Reply-To: <CAOi1vP87GtgauS4OXGXDeBXD3ce_CM+N3p_j8+6XXDsG1TYgwQ@mail.gmail.com>
On Tue, 7 Nov 2017 17:56:51 +0100, Ilya Dryomov wrote:
> Heh, apparently I only tested writes and didn't do discards... Writes
> go through blkdev_write_iter() but zeroout/discards seem to rely solely
> on FMODE_WRITE checks, which the block layer doesn't enforce.
>
> I'd rather try to fix it in the block layer before working around it in
> krbd. I'll work up a patch tomorrow.
FWIW I've pushed a blktests regression test for this to the
wip_ro_get_set_discard branch of my repo at:
https://github.com/ddiss/blktests.git
Cheers, David
prev parent reply other threads:[~2017-11-08 18:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 15:49 [PATCH 1/2] rbd: fix and simplify rbd_ioctl_set_ro() Ilya Dryomov
2017-11-06 15:49 ` [PATCH 2/2] rbd: get rid of rbd_mapping::read_only Ilya Dryomov
2017-11-07 13:26 ` David Disseldorp
2017-11-07 16:56 ` Ilya Dryomov
2017-11-08 18:32 ` David Disseldorp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171108193242.7b3b16c5@suse.de \
--to=ddiss@suse.de \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.