From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/edid: Don't send non-zero YQ in AVI infoframe for HDMI 1.x sinks Date: Wed, 8 Nov 2017 22:45:23 +0200 Message-ID: <20171108204523.GJ10981@intel.com> References: <20171108152504.12596-1-ville.syrjala@linux.intel.com> <87k1z0bk4n.fsf@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <87k1z0bk4n.fsf@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Eric Anholt Cc: Jani Nikula , intel-gfx@lists.freedesktop.org, Neil Kownacki , stable@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBOb3YgMDgsIDIwMTcgYXQgMTI6MTc6MjhQTSAtMDgwMCwgRXJpYyBBbmhvbHQgd3Jv dGU6Cj4gVmlsbGUgU3lyamFsYSA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+IHdyaXRl czoKPiAKPiA+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRl bC5jb20+Cj4gPgo+ID4gQXBwYXJlbnRseSBzb21lIHNpbmtzIGxvb2sgYXQgdGhlIFlRIGJpdHMg ZXZlbiB3aGVuIHJlY2VpdmluZyBSR0IsCj4gPiBhbmQgdGhleSBnZXQgc29tZWhvdyBjb25mdXNl ZCB3aGVuIHRoZXkgc2VlIGEgbm9uLXplcm8gWVEgdmFsdWUuCj4gPiBTbyB3ZSBjYW4ndCBqdXN0 IGJsaW5kbHkgZm9sbG93IENFQS04NjEtRiBhbmQgc2V0IFlRIHRvIG1hdGNoIHRoZQo+ID4gUkdC IHJhbmdlLgo+ID4KPiA+IFVuZm9ydHVuYXRlbHkgdGhlcmUgaXMgbm8gZ29vZCB3YXkgdG8gdGVs bCB3aGV0aGVyIHRoZSBzaW5rCj4gPiBkZXNpZ25lciBjbGFpbXMgdG8gaGF2ZSByZWFkIENFQS04 NjEtRi4gVGhlIENFQSBleHRlbnNpb24gYmxvY2sKPiA+IHJldmlzaW9uIG51bWJlciBoYXMgZ2Vu ZXJhbGx5IGJlZW4gc3R1Y2sgYXQgMyBzaW5jZSBmb3JldmVyLAo+ID4gYW5kIGV2ZW4gYSB2ZXJ5 IHJlY2VudGx5IG1hbnVmYWN0dXJlZCBzaW5rIG1pZ2h0IGJlIGJhc2VkIG9uCj4gPiBhbiBvbGQg ZGVzaWduIHNvIHRoZSBtYW51ZmFjdHVyaW5nIGRhdGUgZG9lc24ndCBzZWVtIGxpa2UKPiA+IHNv bWV0aGluZyB3ZSBjYW4gdXNlLiBJbiBsaWV1IG9mIGJldHRlciBpbmZvcm1hdGlvbiBsZXQncwo+ ID4gZm9sbG93IENFQS04NjEtRiBvbmx5IGZvciBIRE1JIDIuMCBzaW5rcywgc2luY2UgSERNSSAy LjAgaXMKPiA+IGJhc2VkIG9uIENFQS04NjEtRi4gRm9yIEhETUkgMS54IHNpbmtzIHdlJ2xsIGFs d2F5cyBzZXQgWVE9MC4KPiA+Cj4gPiBUaGUgYWx0ZXJuYXRpdmUgd291bGQgb2YgY291cnNlIGJl IHRvIGFsd2F5cyBzZXQgWVE9MC4gQW5kIGlmCj4gPiB3ZSBldmVyIGVuY291bnRlciBhIEhETUkg Mi4wKyBzaW5rIHdpdGggdGhpcyBidWcgdGhhdCdzIHdoYXQKPiA+IHdlJ2xsIHByb2JhYmx5IGhh dmUgdG8gZG8uCj4gCj4gU2hvdWxkIHZjNCBiZSBkb2luZyBhbnl0aGluZyBzcGVjaWFsIGZvciBI RE1JMiBzaW5rcywgaWYgaXQncyBhbiBIRE1JMS40Cj4gc291cmNlPwoKQXMgbG9uZyBhcyB5b3Ug c3RpY2sgdG8gPCAzNDAgTUh6IG1vZGVzIHlvdSBzaG91bGRuJ3QgaGF2ZSB0byBkbwphbnl0aGlu Zy4gRm9yID49MzQwIE1IeiB5b3UnZCBuZWVkIHRvIHVzZSBzb21lIG5ldyBIRE1JIDIuMCBmZWF0 dXJlcy4KCkxvb2tzIGxpa2UgdmM0IGNydGMgLm1vZGVfdmFsaWQoKSBkb2Vzbid0IGRvIG11Y2gu IEkgcHJlc3VtZSBpdCdzIHVwCnRvIGJyaWRnZXMvZW5jb2RlcnMgdG8gZmlsdGVyIG91dCBtb3N0 IHRoaW5ncyB0aGF0IGFyZW4ndCBzdXBwb3J0ZWQ/Cgo+IAo+IFRoYXQgc2FpZCwgYXMgZmFyIGFz IHZjNCwgdGhpcyBwYXRjaCBpcwo+IAo+IEFja2VkLWJ5OiBFcmljIEFuaG9sdCA8ZXJpY0Bhbmhv bHQubmV0PgoKVGEuCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com ([134.134.136.100]:14896 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752207AbdKHUp1 (ORCPT ); Wed, 8 Nov 2017 15:45:27 -0500 Date: Wed, 8 Nov 2017 22:45:23 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Eric Anholt Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, stable@vger.kernel.org, Jani Nikula , Neil Kownacki Subject: Re: [PATCH] drm/edid: Don't send non-zero YQ in AVI infoframe for HDMI 1.x sinks Message-ID: <20171108204523.GJ10981@intel.com> References: <20171108152504.12596-1-ville.syrjala@linux.intel.com> <87k1z0bk4n.fsf@anholt.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87k1z0bk4n.fsf@anholt.net> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Nov 08, 2017 at 12:17:28PM -0800, Eric Anholt wrote: > Ville Syrjala writes: > > > From: Ville Syrj�l� > > > > Apparently some sinks look at the YQ bits even when receiving RGB, > > and they get somehow confused when they see a non-zero YQ value. > > So we can't just blindly follow CEA-861-F and set YQ to match the > > RGB range. > > > > Unfortunately there is no good way to tell whether the sink > > designer claims to have read CEA-861-F. The CEA extension block > > revision number has generally been stuck at 3 since forever, > > and even a very recently manufactured sink might be based on > > an old design so the manufacturing date doesn't seem like > > something we can use. In lieu of better information let's > > follow CEA-861-F only for HDMI 2.0 sinks, since HDMI 2.0 is > > based on CEA-861-F. For HDMI 1.x sinks we'll always set YQ=0. > > > > The alternative would of course be to always set YQ=0. And if > > we ever encounter a HDMI 2.0+ sink with this bug that's what > > we'll probably have to do. > > Should vc4 be doing anything special for HDMI2 sinks, if it's an HDMI1.4 > source? As long as you stick to < 340 MHz modes you shouldn't have to do anything. For >=340 MHz you'd need to use some new HDMI 2.0 features. Looks like vc4 crtc .mode_valid() doesn't do much. I presume it's up to bridges/encoders to filter out most things that aren't supported? > > That said, as far as vc4, this patch is > > Acked-by: Eric Anholt Ta. -- Ville Syrj�l� Intel OTC