From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Moti Haimovsky <motih@mellanox.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v3] net/mlx4: fix Rx packet type offloads
Date: Thu, 9 Nov 2017 10:18:31 +0100 [thread overview]
Message-ID: <20171109091831.GY24849@6wind.com> (raw)
In-Reply-To: <1510217973-178845-1-git-send-email-motih@mellanox.com>
On Thu, Nov 09, 2017 at 10:59:33AM +0200, Moti Haimovsky wrote:
> This patch improves Rx packet type offload report in case the device is
> a virtual function device.
> In these devices we observed that the L2 tunnel flag is set also for
> non-tunneled packets, this leads to a complete misinterpretation of the
> packet type being received.
> This issue occurs since the tunnel_mode is not set to 0x7 by the driver
> for virtual devices and therefore the value in the L2 tunnel flag is
> meaningless and should be ignored.
>
> Fixes: aee4a03fee4f ("net/mlx4: enhance Rx packet type offloads")
>
> Signed-off-by: Moti Haimovsky <motih@mellanox.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> ---
> V3:
> Modified patch headline to reflect that this is a bug fix.
>
> V2:
> Modification according to inputs from Adrien Mazarguil
> * Modified the commit message to explain the issue.
> * Removed redundant l2 tunnel offload bit.
> * Modified mlx4_dev_supported_ptypes_get to report the supported
> packet types according to the device in hand.
--
Adrien Mazarguil
6WIND
next prev parent reply other threads:[~2017-11-09 9:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 18:47 [PATCH v2] net/mlx4: improve Rx packet type offloads report Moti Haimovsky
2017-11-08 19:56 ` Thomas Monjalon
2017-11-09 8:59 ` [PATCH v3] net/mlx4: fix Rx packet type offloads Moti Haimovsky
2017-11-09 9:18 ` Adrien Mazarguil [this message]
2017-11-10 2:32 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171109091831.GY24849@6wind.com \
--to=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=motih@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.