diff for duplicates of <20171109091858.GA16966@lst.de> diff --git a/a/1.txt b/N1/1.txt index 9c0cf13..ca49f57 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,4 +1,4 @@ -On Wed, Nov 08, 2017@12:06:14PM +0200, Sagi Grimberg wrote: +On Wed, Nov 08, 2017 at 12:06:14PM +0200, Sagi Grimberg wrote: > The entire completions suppress mechanism is currently > broken because the HCA might retry a send operation > (due to dropped ack) after the nvme transaction has completed. @@ -13,7 +13,7 @@ we need to fix up a lot of other ULPs as well. Looks fine: -Reviewed-by: Christoph Hellwig <hch at lst.de> +Reviewed-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org> > - */ > - if (nvme_rdma_queue_sig_limit(queue) || flush) @@ -21,3 +21,7 @@ Reviewed-by: Christoph Hellwig <hch at lst.de> > + wr.send_flags = IB_SEND_SIGNALED; But.. Is there any benefit in just setting IB_SIGNAL_ALL_WR on the QP? +-- +To unsubscribe from this list: send the line "unsubscribe linux-rdma" in +the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index c682d3d..0604f79 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,11 +1,17 @@ "ref\020171108100616.26605-1-sagi@grimberg.me\0" "ref\020171108100616.26605-2-sagi@grimberg.me\0" - "From\0hch@lst.de (Christoph Hellwig)\0" - "Subject\0[PATCH v2 1/3] nvme-rdma: don't suppress send completions\0" + "ref\020171108100616.26605-2-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org\0" + "From\0Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>\0" + "Subject\0Re: [PATCH v2 1/3] nvme-rdma: don't suppress send completions\0" "Date\0Thu, 9 Nov 2017 10:18:58 +0100\0" + "To\0Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>\0" + "Cc\0linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" + linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org + Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org> + " Max Gurtuvoy <maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>\0" "\00:1\0" "b\0" - "On Wed, Nov 08, 2017@12:06:14PM +0200, Sagi Grimberg wrote:\n" + "On Wed, Nov 08, 2017 at 12:06:14PM +0200, Sagi Grimberg wrote:\n" "> The entire completions suppress mechanism is currently\n" "> broken because the HCA might retry a send operation\n" "> (due to dropped ack) after the nvme transaction has completed.\n" @@ -20,13 +26,17 @@ "\n" "Looks fine:\n" "\n" - "Reviewed-by: Christoph Hellwig <hch at lst.de>\n" + "Reviewed-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>\n" "\n" "> -\t */\n" "> -\tif (nvme_rdma_queue_sig_limit(queue) || flush)\n" "> -\t\twr.send_flags |= IB_SEND_SIGNALED;\n" "> +\twr.send_flags = IB_SEND_SIGNALED;\n" "\n" - But.. Is there any benefit in just setting IB_SIGNAL_ALL_WR on the QP? + "But.. Is there any benefit in just setting IB_SIGNAL_ALL_WR on the QP?\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe linux-rdma\" in\n" + "the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -2dce47fb0d41edfa4d39f71d086ed8bf66127f867de3e6ff196b4c189e8a2ecf +3094d7745b9339d5f65e47a2fdacd79f1e514eec06ea775abcc0fac35686185e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.