From: Oleg Nesterov <oleg@redhat.com>
To: Yonghong Song <yhs@fb.com>
Cc: mingo@kernel.org, tglx@linutronix.de, peterz@infradead.org,
linux-kernel@vger.kernel.org, x86@kernel.org,
netdev@vger.kernel.org, ast@fb.com, kernel-team@fb.com
Subject: Re: [PATCH] uprobes/x86: emulate push insns for uprobe on x86
Date: Thu, 9 Nov 2017 15:04:16 +0100 [thread overview]
Message-ID: <20171109140416.GA11186@redhat.com> (raw)
In-Reply-To: <20171109134423.GA8746@redhat.com>
On 11/09, Oleg Nesterov wrote:
>
> And. Do you really need ->post_xol() method to emulate "push"? Why we can't
> simply execute it out-of-line if copy_to_user() fails?
>
> branch_post_xol_op() is needed because we can't execute "call" out-of-line,
> we need to restart and try again if copy_to_user() fails, but I don not
> understand why it is needed to emulate "push".
If I wasn't clear, please see the comment in branch_clear_offset().
Oleg.
next prev parent reply other threads:[~2017-11-09 14:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 8:01 [PATCH] uprobes/x86: emulate push insns for uprobe on x86 Yonghong Song
2017-11-09 13:44 ` Oleg Nesterov
2017-11-09 14:04 ` Oleg Nesterov [this message]
2017-11-09 21:53 ` Yonghong Song
2017-11-09 14:47 ` Oleg Nesterov
-- strict thread matches above, loose matches on Subject: below --
2017-11-09 23:02 Yonghong Song
2017-11-10 13:06 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171109140416.GA11186@redhat.com \
--to=oleg@redhat.com \
--cc=ast@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.