From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 0/4] dma-buf: Silence dma_fence __rcu sparse warnings Date: Thu, 9 Nov 2017 21:33:20 +0200 Message-ID: <20171109193320.GC10981@intel.com> References: <20171102200336.23347-1-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id E220D6E982 for ; Thu, 9 Nov 2017 19:33:24 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sumit Semwal Cc: DRI mailing list , Linaro MM SIG , Jason Ekstrand , Alex Deucher , Dave Airlie , Christian =?iso-8859-1?Q?K=F6nig?= , "linux-media@vger.kernel.org" List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBOb3YgMDcsIDIwMTcgYXQgMDE6Mzc6MTBQTSArMDUzMCwgU3VtaXQgU2Vtd2FsIHdy b3RlOgo+IEhpIFZpbGxlLAo+IAo+IE9uIDMgTm92ZW1iZXIgMjAxNyBhdCAxMzoxOCwgQ2hyaXN0 aWFuIEvDtm5pZyA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPiB3cm90ZToKPiA+IFBhdGNoICM0 IGlzIFJldmlld2VkLWJ5OiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5j b20+Lgo+ID4KPiA+IFRoZSByZXN0IGlzIEFja2VkLWJ5OiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJp c3RpYW4ua29lbmlnQGFtZC5jb20+Lgo+ID4KPiA+IFJlZ2FyZHMsCj4gPiBDaHJpc3RpYW4uCj4g Pgo+ID4KPiA+IEFtIDAyLjExLjIwMTcgdW0gMjE6MDMgc2NocmllYiBWaWxsZSBTeXJqYWxhOgo+ ID4+Cj4gPj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVs LmNvbT4KPiA+Pgo+ID4+IFdoZW4gYnVpbGRpbmcgZHJtK2k5MTUgSSBnZXQgYXJvdW5kIDE1MCBs aW5lcyBvZiBzcGFyc2Ugbm9pc2UgZnJvbQo+ID4+IGRtYV9mZW5jZSBfX3JjdSB3YXJuaW5ncy4g VGhpcyBzZXJpZXMgZWxpbWluYXRlcyBhbGwgb2YgdGhhdC4KPiA+Pgo+ID4+IFRoZSBmaXJzdCB0 d28gcGF0Y2hlcyB3ZXJlIGFscmVhZHkgcG9zdGVkIGJ5IENocmlzLCBidXQgdGhlcmUgd2Fzbid0 Cj4gPj4gYW55IHJlYWwgcmVhY3Rpb24sIHNvIEkgZmlndXJlZCBJJ2QgcmVwb3N0IHdpdGggYSB3 aWRlciBDYyBsaXN0Lgo+ID4+Cj4gPj4gQXMgZm9yIHRoZSBvdGhlciB0d28gcGF0Y2hlcywgSSdt IG5vIGV4cGVydCBvbiBkbWFfZmVuY2UgYW5kIEkgZGlkbid0Cj4gPj4gc3BlbmQgYSBsb3Qgb2Yg dGltZSBsb29raW5nIGF0IGl0IHNvIEkgY2FuJ3QgYmUgc3VyZSBJIGFubm90YXRlZCBhbGwKPiA+ PiB0aGUgYWNjZXNzZXMgY29ycmVjdGx5LiBCdXQgSSBmaWd1cmVkIHNvbWVvbmUgd2lsbCBzY3Jl YW0gYXQgbWUgaWYKPiA+PiBJIGdvdCBpdCB3cm9uZyA7KQo+ID4+Cj4gPj4gQ2M6IERhdmUgQWly bGllIDxhaXJsaWVkQHJlZGhhdC5jb20+Cj4gPj4gQ2M6IEphc29uIEVrc3RyYW5kIDxqYXNvbkBq bGVrc3RyYW5kLm5ldD4KPiA+PiBDYzogbGluYXJvLW1tLXNpZ0BsaXN0cy5saW5hcm8ub3JnCj4g Pj4gQ2M6IGxpbnV4LW1lZGlhQHZnZXIua2VybmVsLm9yZwo+ID4+IENjOiBBbGV4IERldWNoZXIg PGFsZXhhbmRlci5kZXVjaGVyQGFtZC5jb20+Cj4gPj4gQ2M6IENocmlzdGlhbiBLw7ZuaWcgPGNo cmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4KPiA+PiBDYzogU3VtaXQgU2Vtd2FsIDxzdW1pdC5zZW13 YWxAbGluYXJvLm9yZz4KPiA+PiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24u Y28udWs+Cj4gPj4KPiA+PiBDaHJpcyBXaWxzb24gKDIpOgo+ID4+ICAgIGRybS9zeW5jb2JqOiBN YXJrIHVwIHRoZSBmZW5jZSBhcyBhbiBSQ1UgcHJvdGVjdGVkIHBvaW50ZXIKPiA+PiAgICBkbWEt YnVmL2ZlbmNlOiBTcGFyc2Ugd2FudHMgX19yY3Ugb24gdGhlIG9iamVjdCBpdHNlbGYKPiA+Pgo+ ID4+IFZpbGxlIFN5cmrDpGzDpCAoMik6Cj4gPj4gICAgZHJtL3N5bmNvYmo6IFVzZSBwcm9wZXIg bWV0aG9kcyBmb3IgYWNjZXNzaW5nIHJjdSBwcm90ZWN0ZWQgcG9pbnRlcnMKPiA+PiAgICBkbWEt YnVmOiBVc2UgcmN1X2Fzc2lnbl9wb2ludGVyKCkgdG8gc2V0IHJjdSBwcm90ZWN0ZWQgcG9pbnRl cnMKPiAKPiBGb3IgcGF0Y2hlcyAyICh3aXRoIERhbmllbCdzIG1pbm9yIGNvbW1lbnQpIGFuZCA0 LCBwbGVhc2UgZmVlbCBmcmVlIHRvIGFkZCBteQo+IEFja2VkLWJ5OiBTdW1pdCBTZW13YWwgPHN1 bWl0LnNlbXdhbEBsaW5hcm8ub3JnLgoKVGhhbmtzIGV2ZXJ5b25lLiBTZXJpZXMgcHVzaGVkIHRv IGRybS1taXNjLW5leHQuCgo+IAo+ID4+Cj4gPj4gICBkcml2ZXJzL2RtYS1idWYvcmVzZXJ2YXRp b24uYyB8ICAyICstCj4gPj4gICBkcml2ZXJzL2dwdS9kcm0vZHJtX3N5bmNvYmouYyB8IDExICsr KysrKystLS0tCj4gPj4gICBpbmNsdWRlL2RybS9kcm1fc3luY29iai5oICAgICB8ICAyICstCj4g Pj4gICBpbmNsdWRlL2xpbnV4L2RtYS1mZW5jZS5oICAgICB8ICAyICstCj4gPj4gICA0IGZpbGVz IGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCj4gPj4KPiA+Cj4gCj4g QmVzdCwKPiBTdW1pdC4KCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga05.intel.com ([192.55.52.43]:43944 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754515AbdKITdY (ORCPT ); Thu, 9 Nov 2017 14:33:24 -0500 Date: Thu, 9 Nov 2017 21:33:20 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Sumit Semwal Cc: Christian =?iso-8859-1?Q?K=F6nig?= , DRI mailing list , Dave Airlie , Jason Ekstrand , Linaro MM SIG , "linux-media@vger.kernel.org" , Alex Deucher , Chris Wilson Subject: Re: [PATCH 0/4] dma-buf: Silence dma_fence __rcu sparse warnings Message-ID: <20171109193320.GC10981@intel.com> References: <20171102200336.23347-1-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-media-owner@vger.kernel.org List-ID: On Tue, Nov 07, 2017 at 01:37:10PM +0530, Sumit Semwal wrote: > Hi Ville, > > On 3 November 2017 at 13:18, Christian König wrote: > > Patch #4 is Reviewed-by: Christian König . > > > > The rest is Acked-by: Christian König . > > > > Regards, > > Christian. > > > > > > Am 02.11.2017 um 21:03 schrieb Ville Syrjala: > >> > >> From: Ville Syrjälä > >> > >> When building drm+i915 I get around 150 lines of sparse noise from > >> dma_fence __rcu warnings. This series eliminates all of that. > >> > >> The first two patches were already posted by Chris, but there wasn't > >> any real reaction, so I figured I'd repost with a wider Cc list. > >> > >> As for the other two patches, I'm no expert on dma_fence and I didn't > >> spend a lot of time looking at it so I can't be sure I annotated all > >> the accesses correctly. But I figured someone will scream at me if > >> I got it wrong ;) > >> > >> Cc: Dave Airlie > >> Cc: Jason Ekstrand > >> Cc: linaro-mm-sig@lists.linaro.org > >> Cc: linux-media@vger.kernel.org > >> Cc: Alex Deucher > >> Cc: Christian König > >> Cc: Sumit Semwal > >> Cc: Chris Wilson > >> > >> Chris Wilson (2): > >> drm/syncobj: Mark up the fence as an RCU protected pointer > >> dma-buf/fence: Sparse wants __rcu on the object itself > >> > >> Ville Syrjälä (2): > >> drm/syncobj: Use proper methods for accessing rcu protected pointers > >> dma-buf: Use rcu_assign_pointer() to set rcu protected pointers > > For patches 2 (with Daniel's minor comment) and 4, please feel free to add my > Acked-by: Sumit Semwal > >> > >> drivers/dma-buf/reservation.c | 2 +- > >> drivers/gpu/drm/drm_syncobj.c | 11 +++++++---- > >> include/drm/drm_syncobj.h | 2 +- > >> include/linux/dma-fence.h | 2 +- > >> 4 files changed, 10 insertions(+), 7 deletions(-) > >> > > > > Best, > Sumit. -- Ville Syrjälä Intel OTC