All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@savoirfairelinux.com,
	"David S. Miller" <davem@davemloft.net>,
	Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH net-next] Revert "net: dsa: constify cpu_dp member of dsa_port"
Date: Thu, 9 Nov 2017 23:06:14 +0100	[thread overview]
Message-ID: <20171109220614.GA23613@lunn.ch> (raw)
In-Reply-To: <20171109143932.6923-1-vivien.didelot@savoirfairelinux.com>

On Thu, Nov 09, 2017 at 09:39:32AM -0500, Vivien Didelot wrote:
> We may have to pass a port's dedicated CPU port to port-wide functions
> such as dsa_port_mdb_add, e.g. when offloading bridge device's MDB.
> 
> The DSA port-wide functions currently take a non-const struct dsa_port *
> as first argument so we cannot make cpu_dp const yet, even though it'd
> be more correct. Revert this patch and make cpu_dp non-const again.

Hi Vivien

We cannot make cpu_dp const yet. But we can change dsa_port_mdb_add()
and friends to take a const, because they don't need to modify it.

So NACK.

And i will add the needed const attributes to these functions as part
of the IGMP patchset.

    Andrew

  parent reply	other threads:[~2017-11-09 22:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-09 14:39 [PATCH net-next] Revert "net: dsa: constify cpu_dp member of dsa_port" Vivien Didelot
2017-11-09 19:47 ` Florian Fainelli
2017-11-09 22:06 ` Andrew Lunn [this message]
2017-11-09 22:21   ` Vivien Didelot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171109220614.GA23613@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=kernel@savoirfairelinux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.