From: Kalle Valo <kvalo@codeaurora.org>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: linux-wireless@vger.kernel.org,
Richard Genoud <richard.genoud@gmail.com>
Subject: Re: rt2x00usb: mark device removed when get ENOENT usb error
Date: Fri, 10 Nov 2017 02:32:42 +0000 (UTC) [thread overview]
Message-ID: <20171110023242.0DBF0601D1@smtp.codeaurora.org> (raw)
In-Reply-To: <20171109105917.GA3206@redhat.com>
Stanislaw Gruszka <sgruszka@redhat.com> wrote:
> ENOENT usb error mean "specified interface or endpoint does not exist or
> is not enabled". Mark device not present when we encounter this error
> similar like we do with ENODEV error.
>
> Otherwise we can have infinite loop in rt2x00usb_work_rxdone(), because
> we remove and put again RX entries to the queue infinitely.
>
> We can have similar situation when submit urb will fail all the time
> with other error, so we need consider to limit number of entries
> processed by rxdone work. But for now, since the patch fixes
> reproducible soft lockup issue on single processor systems
> and taken ENOENT error meaning, let apply this fix.
>
> Patch adds additional ENOENT check not only in rx kick routine, but
> also on other places where we check for ENODEV error.
>
> Reported-by: Richard Genoud <richard.genoud@gmail.com>
> Debugged-by: Richard Genoud <richard.genoud@gmail.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> Tested-by: Richard Genoud <richard.genoud@gmail.com>
Patch applied to wireless-drivers-next.git, thanks.
bfa62a52cad9 rt2x00usb: mark device removed when get ENOENT usb error
--
https://patchwork.kernel.org/patch/10050781/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2017-11-10 2:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 10:59 [PATCH] rt2x00usb: mark device removed when get ENOENT usb error Stanislaw Gruszka
2017-11-09 11:58 ` Richard Genoud
2017-11-10 2:32 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171110023242.0DBF0601D1@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=richard.genoud@gmail.com \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.