From: Christoph Hellwig <hch@lst.de>
To: Huacai Chen <chenhc@lemote.com>
Cc: Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Fuxin Zhang <zhangfx@lemote.com>,
linux-kernel@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
James Hogan <james.hogan@imgtec.com>,
linux-mips@linux-mips.org,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, stable@vger.kernel.org,
"Michael S . Tsirkin" <mst@redhat.com>,
Pawel Osciak <pawel@osciak.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Michael Chan <michael.chan@broadcom.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Ivan Mikhaylov <ivan@ru.ibm.com>,
Tariq Toukan <tariqt@mellanox.com>,
Andy Gross <agross@codeaurora.org>,
"Mark A . Greer" <mgreer@animalcreek.com>,
Robert Baldyga <r.baldyga@hackerion.com>
Subject: Re: [PATCH V9 1/4] dma-mapping: Rework dma_get_cache_alignment()
Date: Fri, 10 Nov 2017 13:30:59 +0100 [thread overview]
Message-ID: <20171110123059.GA9296@lst.de> (raw)
In-Reply-To: <1508742767-28366-1-git-send-email-chenhc@lemote.com>
> diff --git a/drivers/net/ethernet/broadcom/b44.c b/drivers/net/ethernet/broadcom/b44.c
> index a1125d1..2f6ffe5 100644
> --- a/drivers/net/ethernet/broadcom/b44.c
> +++ b/drivers/net/ethernet/broadcom/b44.c
> @@ -2344,6 +2344,10 @@ static int b44_init_one(struct ssb_device *sdev,
> struct net_device *dev;
> struct b44 *bp;
> int err;
> + unsigned int dma_desc_align_size = dma_get_cache_alignment(sdev->dma_dev);
> +
> + /* Setup paramaters for syncing RX/TX DMA descriptors */
> + dma_desc_sync_size = max_t(unsigned int, dma_desc_align_size, sizeof(struct dma_desc));
>
> instance++;
>
> @@ -2587,12 +2591,8 @@ static inline void b44_pci_exit(void)
>
> static int __init b44_init(void)
> {
> - unsigned int dma_desc_align_size = dma_get_cache_alignment();
> int err;
>
> - /* Setup paramaters for syncing RX/TX DMA descriptors */
> - dma_desc_sync_size = max_t(unsigned int, dma_desc_align_size, sizeof(struct dma_desc));
> -
This looks wrong - you override a global variable for each probed
device.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Huacai Chen <chenhc@lemote.com>
Cc: Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Fuxin Zhang <zhangfx@lemote.com>,
linux-kernel@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
James Hogan <james.hogan@imgtec.com>,
linux-mips@linux-mips.org,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, stable@vger.kernel.org,
"Michael S . Tsirkin" <mst@redhat.com>,
Pawel Osciak <pawel@osciak.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Michael Chan <michael.chan@broadcom.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Ivan Mikhaylov <ivan@ru.ibm.com>,
Tariq Toukan <tariqt@mellanox.com>
Subject: Re: [PATCH V9 1/4] dma-mapping: Rework dma_get_cache_alignment()
Date: Fri, 10 Nov 2017 13:30:59 +0100 [thread overview]
Message-ID: <20171110123059.GA9296@lst.de> (raw)
In-Reply-To: <1508742767-28366-1-git-send-email-chenhc@lemote.com>
> diff --git a/drivers/net/ethernet/broadcom/b44.c b/drivers/net/ethernet/broadcom/b44.c
> index a1125d1..2f6ffe5 100644
> --- a/drivers/net/ethernet/broadcom/b44.c
> +++ b/drivers/net/ethernet/broadcom/b44.c
> @@ -2344,6 +2344,10 @@ static int b44_init_one(struct ssb_device *sdev,
> struct net_device *dev;
> struct b44 *bp;
> int err;
> + unsigned int dma_desc_align_size = dma_get_cache_alignment(sdev->dma_dev);
> +
> + /* Setup paramaters for syncing RX/TX DMA descriptors */
> + dma_desc_sync_size = max_t(unsigned int, dma_desc_align_size, sizeof(struct dma_desc));
>
> instance++;
>
> @@ -2587,12 +2591,8 @@ static inline void b44_pci_exit(void)
>
> static int __init b44_init(void)
> {
> - unsigned int dma_desc_align_size = dma_get_cache_alignment();
> int err;
>
> - /* Setup paramaters for syncing RX/TX DMA descriptors */
> - dma_desc_sync_size = max_t(unsigned int, dma_desc_align_size, sizeof(struct dma_desc));
> -
This looks wrong - you override a global variable for each probed
device.
next prev parent reply other threads:[~2017-11-10 12:31 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171023071025epcas4p3e9b9c0af7c0a34561f0d57a20a4f9946@epcas4p3.samsung.com>
2017-10-23 7:12 ` [PATCH V9 1/4] dma-mapping: Rework dma_get_cache_alignment() Huacai Chen
2017-10-23 7:12 ` Huacai Chen
2017-10-23 7:12 ` [PATCH V9 2/4] MIPS: Implement dma_map_ops::get_cache_alignment() Huacai Chen
2017-11-06 18:21 ` Christoph Hellwig
2017-10-23 7:12 ` [PATCH V9 3/4] scsi: Align block queue to dma_get_cache_alignment() Huacai Chen
2017-11-05 2:39 ` kbuild test robot
2017-11-05 2:39 ` kbuild test robot
2017-11-05 2:39 ` kbuild test robot
2017-10-23 7:12 ` [PATCH V9 4/4] libsas: Align sata_device's rps_resp on a cacheline Huacai Chen
2017-10-24 13:30 ` [PATCH V9 1/4] dma-mapping: Rework dma_get_cache_alignment() Marek Szyprowski
2017-10-24 13:30 ` Marek Szyprowski
2017-10-25 1:22 ` 陈华才
2017-10-25 1:22 ` 陈华才
2017-10-25 7:21 ` Marek Szyprowski
2017-10-25 7:21 ` Marek Szyprowski
2017-10-26 6:33 ` 陈华才
2017-10-26 6:33 ` 陈华才
2017-11-03 4:48 ` 陈华才
2017-11-03 4:48 ` 陈华才
2017-11-03 5:14 ` Christoph Hellwig
2017-11-03 5:14 ` Christoph Hellwig
2017-11-03 6:15 ` 陈华才
2017-11-03 6:15 ` 陈华才
2017-10-24 19:11 ` Mark Greer
2017-10-24 19:11 ` Mark Greer
2017-11-06 18:18 ` Christoph Hellwig
2017-11-06 18:18 ` Christoph Hellwig
2017-11-10 12:30 ` Christoph Hellwig [this message]
2017-11-10 12:30 ` Christoph Hellwig
2017-11-13 8:37 ` 陈华才
2017-11-13 8:37 ` 陈华才
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171110123059.GA9296@lst.de \
--to=hch@lst.de \
--cc=agross@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=chenhc@lemote.com \
--cc=ivan@ru.ibm.com \
--cc=james.hogan@imgtec.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-scsi@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=martin.petersen@oracle.com \
--cc=mgreer@animalcreek.com \
--cc=michael.chan@broadcom.com \
--cc=mst@redhat.com \
--cc=pawel@osciak.com \
--cc=r.baldyga@hackerion.com \
--cc=ralf@linux-mips.org \
--cc=robin.murphy@arm.com \
--cc=stable@vger.kernel.org \
--cc=tariqt@mellanox.com \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.