From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eDACq-0004Kb-No for qemu-devel@nongnu.org; Fri, 10 Nov 2017 09:22:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eDACm-0001tH-QF for qemu-devel@nongnu.org; Fri, 10 Nov 2017 09:22:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56128) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eDACm-0001rM-GI for qemu-devel@nongnu.org; Fri, 10 Nov 2017 09:22:48 -0500 Date: Fri, 10 Nov 2017 14:22:40 +0000 From: "Daniel P. Berrange" Message-ID: <20171110142240.GC30685@redhat.com> Reply-To: "Daniel P. Berrange" References: <7967e55c-de72-6ef2-eb92-a85af8fc2552@redhat.com> <96ded936-f9e3-c712-291e-fcb3d44bbe65@amsat.org> <20171108130102.GS12670@redhat.com> <20171110104135.GB30685@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] Yet another git submodule rant List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Peter Maydell , Thomas Huth , QEMU Developers , "Emilio G. Cota" , Gerd Hoffmann , Michal =?utf-8?B?U3VjaMOhbmVr?= On Sat, Nov 11, 2017 at 12:46:36AM +1100, Alexey Kardashevskiy wrote: > On 10/11/17 21:41, Daniel P. Berrange wrote: > > On Fri, Nov 10, 2017 at 09:35:54PM +1100, Alexey Kardashevskiy wrote: > >> On 09/11/17 00:01, Daniel P. Berrange wrote: > >>> On Wed, Nov 08, 2017 at 09:26:01AM -0300, Philippe Mathieu-Daud=C3=A9= wrote: > >>>> On 11/08/2017 06:57 AM, Thomas Huth wrote: > >>>>> > >>>>> That automatic git submodule stuff now broke my workflow again. I > >>>>> usually keep the git repository on my laptop and then simply rsyn= c the > >>>>> sources (without .git directories) to my target machine to compil= e it > >>>>> there. Used to work great for years. Now it's broken, the build p= rocess > >>>>> complains: > >>>>> > >>>>> GIT submodule checkout is out of date. Please run > >>>>> scripts/git-submodule.sh update > >>>>> from the source directory checkout /home/thuth/devel/qemu > >>>>> > >>>>> Running "scripts/git-submodule.sh update" did not fix the issue a= t all - > >>>>> I first had to tinker with it for a while to find out that I simp= ly have > >>>>> to delete ".git-submodule-status" in my git tree to fix the issue= . > >>>>> > >>>>> I've got the feeling that all this submodule crap is constantly c= ausing > >>>>> pain ... do we really need this? Can't we find another solution i= nstead? > >>>>> Or at least stop modifying files automatically in the $SRC_PATH ? > >>>> > >>>> Also yesterday on IRC: > >>>> > >>>> [...] I downloaded the qemu source from git and tried to c= ompile > >>>> it. I am getting this: > >>>> > >>>> ./configure --static && make && sudo make install > >>>> CC ui/input-keymap.o > >>>> ui/input-keymap.c:8:10: fatal error: ui/input-keymap-linux-to-qcod= e.c: > >>>> No such file or directory > >>> > >>> I had a pull request merged yesterday later afternoon which possibl= y > >>> would address that problem, though hard hard to say for certain. > >> > >> wow, already? :( > >> > >> I still wonder why do not we checkout submodules into the build dire= ctory > >> and why .git-submodule-status is not there too... > >=20 > > That simply isn't the way submodules work, they are inherently part o= f > > the source tree, and the status file reflects that too. >=20 > Sorry, I am missing the point here. What precisely does prevent us from > checking out the required modules to the build directory and build them > there? git provides a submodule repository url and sha1 for the current > qemu branch. The build directory should never contain any of your version controlled source, as that will get irretrievably lost when the build dir is purged. Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|