From: Lawrence Brakmo <brakmo@fb.com>
To: netdev <netdev@vger.kernel.org>
Cc: Alexei Starovoitov <ast@fb.com>, Daniel Borkmann <daniel@iogearbox.net>
Subject: [PATCH net-next 4/6] bpf: Fix tcp_cong_kern.c sample program
Date: Fri, 10 Nov 2017 12:43:01 -0800 [thread overview]
Message-ID: <20171110204303.1840413-5-brakmo@fb.com> (raw)
In-Reply-To: <20171110204303.1840413-1-brakmo@fb.com>
The program was returning -1 in some cases which is not allowed
by the verifier any longer.
Fixes: bb56d4449d8b ("bpf: Sample BPF program to set congestion control")
Signed-off-by: Lawrence Brakmo <brakmo@fb.com>
---
samples/bpf/tcp_cong_kern.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/samples/bpf/tcp_cong_kern.c b/samples/bpf/tcp_cong_kern.c
index dac15bc..ad0f1ba 100644
--- a/samples/bpf/tcp_cong_kern.c
+++ b/samples/bpf/tcp_cong_kern.c
@@ -39,8 +39,10 @@ int bpf_cong(struct bpf_sock_ops *skops)
* if neither port numberis 55601
*/
if (bpf_ntohl(skops->remote_port) != 55601 &&
- skops->local_port != 55601)
- return -1;
+ skops->local_port != 55601) {
+ skops->reply = -1;
+ return 1;
+ }
op = (int) skops->op;
--
2.9.5
next prev parent reply other threads:[~2017-11-10 20:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 20:42 [PATCH net-next 0/6] bpf: Fix bugs in sock_ops samples In-Reply-To: Lawrence Brakmo
2017-11-10 20:42 ` [PATCH net-next 1/6] bpf: Fix tcp_synrto_kern.c sample program Lawrence Brakmo
2017-11-10 21:18 ` Daniel Borkmann
2017-11-10 20:42 ` [PATCH net-next 2/6] bpf: Fix tcp_rwnd_kern.c " Lawrence Brakmo
2017-11-10 20:43 ` [PATCH net-next 3/6] bpf: Fix tcp_bufs_kern.c " Lawrence Brakmo
2017-11-10 20:43 ` Lawrence Brakmo [this message]
2017-11-10 20:43 ` [PATCH net-next 5/6] bpf: Fix tcp_iw_kern.c " Lawrence Brakmo
2017-11-10 20:43 ` [PATCH net-next 6/6] bpf: Fix tcp_clamp_kern.c " Lawrence Brakmo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171110204303.1840413-5-brakmo@fb.com \
--to=brakmo@fb.com \
--cc=ast@fb.com \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.