All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Liran Alon <liran.alon@oracle.com>
Cc: pbonzini@redhat.com, kvm@vger.kernel.org, jmattson@google.com,
	idan.brown@oracle.com,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH v2] KVM: nVMX/nSVM: Don't intercept #UD when running L2
Date: Fri, 10 Nov 2017 22:37:41 +0100	[thread overview]
Message-ID: <20171110213740.GD2189@flask> (raw)
In-Reply-To: <1509977710-29704-1-git-send-email-liran.alon@oracle.com>

2017-11-06 16:15+0200, Liran Alon:
> When running L2, #UD should be intercepted by L1 or just forwarded
> directly to L2. It should not reach L0 x86 emulator.
> Therefore, set intercept for #UD only based on L1 exception-bitmap.
> 
> Also add WARN_ON_ONCE() on L0 #UD intercept handlers to make sure
> it is never reached while running L2.
> 
> This improves commit ae1f57670703 ("KVM: nVMX: Do not emulate #UD while
> in guest mode") by removing an unnecessary exit from L2 to L0 on #UD
> when L1 doesn't intercept it.
> 
> In addition, SVM L0 #UD intercept handler doesn't handle correctly the
> case it is raised from L2. In this case, it should forward the #UD to
> guest instead of x86 emulator. As done in VMX #UD intercept handler.
> This commit fixes this issue as-well.
> 
> Signed-off-by: Liran Alon <liran.alon@oracle.com>
> Reviewed-by: Nikita Leshenko <nikita.leshchenko@oracle.com>
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---

Applied, thanks.

  parent reply	other threads:[~2017-11-10 21:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-06 14:15 [PATCH v2] KVM: nVMX/nSVM: Don't intercept #UD when running L2 Liran Alon
2017-11-06 14:16 ` Paolo Bonzini
2017-11-07  1:23 ` Wanpeng Li
2017-11-10 21:37 ` Radim Krčmář [this message]
2017-12-01 23:00   ` Jim Mattson
2017-12-01 23:08     ` Jim Mattson
2017-12-02  0:27     ` Liran Alon
2018-01-10 19:56       ` Jim Mattson
  -- strict thread matches above, loose matches on Subject: below --
2018-01-10 23:01 Liran Alon
2018-01-11 10:34 ` Paolo Bonzini
2018-01-11 13:29 Liran Alon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171110213740.GD2189@flask \
    --to=rkrcmar@redhat.com \
    --cc=idan.brown@oracle.com \
    --cc=jmattson@google.com \
    --cc=konrad.wilk@oracle.com \
    --cc=kvm@vger.kernel.org \
    --cc=liran.alon@oracle.com \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.