All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: x86@kernel.org, Dave Hansen <dave.hansen@linux.intel.com>
Subject: [PATCH 3/4] x86, selftests, protection_keys: rename si_pkey
Date: Fri, 10 Nov 2017 16:12:31 -0800	[thread overview]
Message-ID: <20171111001231.DFFC8285@viggo.jf.intel.com> (raw)
In-Reply-To: <20171111001226.810E7A73@viggo.jf.intel.com>


si_pkey is now #defined to be the name of the new siginfo field that
protection keys uses.  Rename it not to conflict.

---

 b/tools/testing/selftests/x86/protection_keys.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff -puN tools/testing/selftests/x86/protection_keys.c~x86-selftests-protection-keys-si_pkeys tools/testing/selftests/x86/protection_keys.c
--- a/tools/testing/selftests/x86/protection_keys.c~x86-selftests-protection-keys-si_pkeys	2017-11-10 15:29:25.380207948 -0800
+++ b/tools/testing/selftests/x86/protection_keys.c	2017-11-10 15:29:25.384207948 -0800
@@ -250,7 +250,7 @@ void signal_handler(int signum, siginfo_
 	unsigned long ip;
 	char *fpregs;
 	u32 *pkru_ptr;
-	u64 si_pkey;
+	u64 siginfo_pkey;
 	u32 *si_pkey_ptr;
 	int pkru_offset;
 	fpregset_t fpregset;
@@ -292,9 +292,9 @@ void signal_handler(int signum, siginfo_
 	si_pkey_ptr = (u32 *)(((u8 *)si) + si_pkey_offset);
 	dprintf1("si_pkey_ptr: %p\n", si_pkey_ptr);
 	dump_mem(si_pkey_ptr - 8, 24);
-	si_pkey = *si_pkey_ptr;
-	pkey_assert(si_pkey < NR_PKEYS);
-	last_si_pkey = si_pkey;
+	siginfo_pkey = *si_pkey_ptr;
+	pkey_assert(siginfo_pkey < NR_PKEYS);
+	last_si_pkey = siginfo_pkey;
 
 	if ((si->si_code == SEGV_MAPERR) ||
 	    (si->si_code == SEGV_ACCERR) ||
@@ -306,7 +306,7 @@ void signal_handler(int signum, siginfo_
 	dprintf1("signal pkru from xsave: %08x\n", *pkru_ptr);
 	/* need __rdpkru() version so we do not do shadow_pkru checking */
 	dprintf1("signal pkru from  pkru: %08x\n", __rdpkru());
-	dprintf1("si_pkey from siginfo: %jx\n", si_pkey);
+	dprintf1("pkey from siginfo: %jx\n", siginfo_pkey);
 	*(u64 *)pkru_ptr = 0x00000000;
 	dprintf1("WARNING: set PRKU=0 to allow faulting instruction to continue\n");
 	pkru_faults++;
_

  parent reply	other threads:[~2017-11-11  0:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-11  0:12 [PATCH 0/4] MPX and Protection Keys Updates Dave Hansen
2017-11-11  0:12 ` [PATCH 1/4] x86, pkeys: update documentation about availability Dave Hansen
2017-11-21  8:39   ` [tip:x86/urgent] x86/pkeys: Update " tip-bot for Dave Hansen
2017-11-11  0:12 ` [PATCH 2/4] x86, selftests, mpx: fix up weird arrays Dave Hansen
2017-11-21  8:32   ` Ingo Molnar
2017-11-21  8:40   ` [tip:x86/urgent] x86/mpx/selftests: Fix " tip-bot for Dave Hansen
2017-11-11  0:12 ` Dave Hansen [this message]
2017-11-21  8:32   ` [PATCH 3/4] x86, selftests, protection_keys: rename si_pkey Ingo Molnar
2017-11-21  8:40   ` [tip:x86/urgent] x86/pkeys/selftests: Rename 'si_pkey' to 'siginfo_pkey' tip-bot for Dave Hansen
2017-11-11  0:12 ` [PATCH 4/4] x86, selftests: fix protection keys write() warining Dave Hansen
2017-11-21  8:41   ` [tip:x86/urgent] x86/pkeys/selftests: Fix protection keys write() warning tip-bot for Dave Hansen
2017-11-21  8:34 ` [PATCH 0/4] MPX and Protection Keys Updates Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171111001231.DFFC8285@viggo.jf.intel.com \
    --to=dave.hansen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.