From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Finn Thain <fthain@telegraphics.com.au>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 14/14] nubus: Add support for the driver model
Date: Sat, 11 Nov 2017 09:46:53 +0100 [thread overview]
Message-ID: <20171111084653.GB6403@kroah.com> (raw)
In-Reply-To: <20171111084553.GA6403@kroah.com>
On Sat, Nov 11, 2017 at 09:45:53AM +0100, Greg Kroah-Hartman wrote:
> On Sat, Nov 11, 2017 at 01:12:49AM -0500, Finn Thain wrote:
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Tested-by: Stan Johnson <userm57@yahoo.com>
> > Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
> > ---
>
> I can't take patches without any changelog text at all, that's not good
> engineering, sorry :(
>
> Please fix up and resend and I will be glad to review.
Also, please test device removal, I don't think you did that :(
next prev parent reply other threads:[~2017-11-11 8:46 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-11 6:12 [PATCH 00/14] Modernization and fixes for NuBus subsystem Finn Thain
2017-11-11 6:12 ` [PATCH 04/14] nubus: Fix log spam Finn Thain
2017-11-11 15:04 ` Joe Perches
2017-11-11 23:47 ` Finn Thain
2017-11-12 0:08 ` Joe Perches
2017-11-11 6:12 ` [PATCH 02/14] nubus: Fix up header split Finn Thain
2017-11-11 6:12 ` [PATCH 06/14] nubus: Call proc_mkdir() not more than once per slot Finn Thain
2017-11-11 6:12 ` [PATCH 01/14] nubus: Avoid array underflow and overflow Finn Thain
2017-11-11 6:12 ` [PATCH 09/14] nubus: Don't needlessly unpack vidname and driver resources Finn Thain
2017-11-11 6:12 ` [PATCH 08/14] nubus: Clean up whitespace Finn Thain
2017-11-11 6:12 ` [PATCH 07/14] nubus: Remove redundant code Finn Thain
2017-11-11 6:12 ` [PATCH 03/14] nubus: Use static functions where possible Finn Thain
2017-11-11 6:12 ` [PATCH 11/14] nubus: Repopulate /proc/bus/nubus/s/ Finn Thain
2017-11-13 8:56 ` Geert Uytterhoeven
2017-11-14 0:21 ` Finn Thain
2017-11-11 6:12 ` [PATCH 10/14] nubus: Depopulate /proc/bus/nubus/s/ Finn Thain
2017-11-11 6:12 ` [PATCH 05/14] nubus: Validate slot resource IDs Finn Thain
2017-11-11 6:12 ` [PATCH 12/14] nubus: Rename struct nubus_dev Finn Thain
2017-11-11 6:12 ` Finn Thain
2017-11-13 8:57 ` Geert Uytterhoeven
2017-11-13 8:57 ` Geert Uytterhoeven
2017-11-14 0:18 ` Finn Thain
2017-11-14 0:18 ` Finn Thain
2017-11-11 6:12 ` [PATCH 13/14] nubus: Add expansion_type values for various Mac models Finn Thain
2017-11-11 6:12 ` [PATCH 14/14] nubus: Add support for the driver model Finn Thain
2017-11-11 8:45 ` Greg Kroah-Hartman
2017-11-11 8:46 ` Greg Kroah-Hartman [this message]
2017-11-12 3:52 ` Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171111084653.GB6403@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=fthain@telegraphics.com.au \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.