From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: spi->irq == 0 on module reload of driver using IRQF_TRIGGER_LOW Date: Sun, 12 Nov 2017 19:19:30 +0100 Message-ID: <20171112181930.GG30830@lunn.ch> References: <21FDD1B8-E8F6-4DCE-9D30-D82B713B0008@martin.sperl.org> <20171112141349.6b4b3852@why.wild-wind.fr.eu.org> <20171112154101.483d21d2@why.wild-wind.fr.eu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-rpi-kernel , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-spi To: Marc Zyngier , kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org Return-path: Content-Disposition: inline In-Reply-To: <20171112154101.483d21d2-Fmn/x+r+pSA9//JtdbceeD8Kkb2uy4ct@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: > > +&spi { > > + status = "okay"; > > + > > + can0: mcp2517fd@0 { > > + reg = <0>; > > + compatible = "microchip,mcp2517fd"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&can0_pins>; > > + spi-max-frequency = <12500000>; > > + interrupt-parent = <&gpio>; > > + interrupts = <16 0x2>; > > This indicates a falling edge. No wonder the kernel is confused (I > don't know why this isn't enforced the first time though, probably an > issue in the GPIO irqchip driver...). Replacing this 2 with a 8 should > allow you to make some progress. And using IRQ_TYPE_LEVEL_LOW, from interrupt-controller/irq.h would make it readable. Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: andrew@lunn.ch (Andrew Lunn) Date: Sun, 12 Nov 2017 19:19:30 +0100 Subject: spi->irq == 0 on module reload of driver using IRQF_TRIGGER_LOW In-Reply-To: <20171112154101.483d21d2@why.wild-wind.fr.eu.org> References: <21FDD1B8-E8F6-4DCE-9D30-D82B713B0008@martin.sperl.org> <20171112141349.6b4b3852@why.wild-wind.fr.eu.org> <20171112154101.483d21d2@why.wild-wind.fr.eu.org> Message-ID: <20171112181930.GG30830@lunn.ch> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > > +&spi { > > + status = "okay"; > > + > > + can0: mcp2517fd at 0 { > > + reg = <0>; > > + compatible = "microchip,mcp2517fd"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&can0_pins>; > > + spi-max-frequency = <12500000>; > > + interrupt-parent = <&gpio>; > > + interrupts = <16 0x2>; > > This indicates a falling edge. No wonder the kernel is confused (I > don't know why this isn't enforced the first time though, probably an > issue in the GPIO irqchip driver...). Replacing this 2 with a 8 should > allow you to make some progress. And using IRQ_TYPE_LEVEL_LOW, from interrupt-controller/irq.h would make it readable. Andrew