From: Andrew Lunn <andrew@lunn.ch>
To: Pan Bian <bianpan2016@163.com>
Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] net: dsa: lan9303: correctly check return value of devm_gpiod_get_optional
Date: Sun, 12 Nov 2017 19:29:21 +0100 [thread overview]
Message-ID: <20171112182921.GI30830@lunn.ch> (raw)
In-Reply-To: <1510501089-9451-1-git-send-email-bianpan2016@163.com>
On Sun, Nov 12, 2017 at 11:38:09PM +0800, Pan Bian wrote:
> Function devm_gpiod_get_optional() returns an ERR_PTR on failure. Its
> return value should not be validated by a NULL check. Instead, use IS_ERR.
>
> Signed-off-by: Pan Bian <bianpan2016@163.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2017-11-12 18:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-12 15:38 [PATCH] net: dsa: lan9303: correctly check return value of devm_gpiod_get_optional Pan Bian
2017-11-12 18:29 ` Andrew Lunn [this message]
2017-11-13 4:08 ` Phil Reid
2017-11-13 4:38 ` Andrew Lunn
2017-11-14 12:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171112182921.GI30830@lunn.ch \
--to=andrew@lunn.ch \
--cc=bianpan2016@163.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.