From: Tomasz Majchrzak <tomasz.majchrzak@intel.com>
To: Jes Sorensen <jsorensen@fb.com>
Cc: Mariusz Tkaczyk <mariusz.tkaczyk@intel.com>, linux-raid@vger.kernel.org
Subject: Re: [PATCH] sysfs: include faulty drive in disk count
Date: Mon, 13 Nov 2017 09:09:19 +0100 [thread overview]
Message-ID: <20171113080919.GA8293@proton.igk.intel.com> (raw)
In-Reply-To: <f8739ccc-3ca5-ed7a-4b3b-30e867a4f5de@fb.com>
On Thu, Nov 09, 2017 at 03:46:08PM -0500, Jes Sorensen wrote:
> On 11/07/2017 10:49 AM, Mariusz Tkaczyk wrote:
> > When the disk fails, it goes into faulty state first and it is removed
> > from the array in a while. It gives mdadm monitor a chance to see the disk
> > has failed and notify an event (e.g. FailSpare). It doesn't work when
> > sysfs is used to get a number of disks in the array as it skips faulty
> > disk. ioctl implementation doesn't differentiate between active and
> > faulty disk. Do the same for sysfs then. It should not matter that number
> > of disks reported is greater than list of disk structures returned by the
> > call because the same approach already takes place for offline disks.
> >
> > Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk@intel.com>
> > ---
> > sysfs.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Applied!
>
> Thanks,
> Jes
Hi Jes,
Have you applied this patch? I don't see it on the repository. I see you
applied "imsm: More precise message when spanned raid is created" but you
haven't confirmed it by email.
Tomek
next prev parent reply other threads:[~2017-11-13 8:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 15:49 [PATCH] sysfs: include faulty drive in disk count Mariusz Tkaczyk
2017-11-09 20:46 ` Jes Sorensen
2017-11-13 8:09 ` Tomasz Majchrzak [this message]
2017-11-13 13:14 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171113080919.GA8293@proton.igk.intel.com \
--to=tomasz.majchrzak@intel.com \
--cc=jsorensen@fb.com \
--cc=linux-raid@vger.kernel.org \
--cc=mariusz.tkaczyk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.