From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752726AbdKMLwc (ORCPT ); Mon, 13 Nov 2017 06:52:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50614 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752493AbdKMLwb (ORCPT ); Mon, 13 Nov 2017 06:52:31 -0500 Date: Mon, 13 Nov 2017 12:52:29 +0100 From: Jiri Olsa To: Wang Nan Cc: linux-kernel@vger.kernel.org, kan.liang@intel.com, acme@kernel.org, namhyung@kernel.org Subject: Re: [PATCH 6/7] perf tools: Remove 'overwrite' concept from code level Message-ID: <20171113115229.GB3017@krava> References: <20171113013809.212417-1-wangnan0@huawei.com> <20171113013809.212417-7-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171113013809.212417-7-wangnan0@huawei.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 13 Nov 2017 11:52:31 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 13, 2017 at 01:38:08AM +0000, Wang Nan wrote: SNIP > size_t perf_mmap__mmap_len(struct perf_mmap *map); > diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c > index c129e99..ece33b4 100644 > --- a/tools/perf/util/python.c > +++ b/tools/perf/util/python.c > @@ -856,14 +856,14 @@ static PyObject *pyrf_evlist__mmap(struct pyrf_evlist *pevlist, > PyObject *args, PyObject *kwargs) > { > struct perf_evlist *evlist = &pevlist->evlist; > - static char *kwlist[] = { "pages", "overwrite", NULL }; unlikely, but there might be already some users of this.. I think the best would be to keep the "overwrite" here and don't use it.. maybe warn or update docs, if there's any ;-) jirka > - int pages = 128, overwrite = false; > + static char *kwlist[] = { "pages", NULL }; > + int pages = 128; > > - if (!PyArg_ParseTupleAndKeywords(args, kwargs, "|ii", kwlist, > - &pages, &overwrite)) > + if (!PyArg_ParseTupleAndKeywords(args, kwargs, "|i", kwlist, > + &pages)) > return NULL; > > - if (perf_evlist__mmap(evlist, pages, overwrite) < 0) { > + if (perf_evlist__mmap(evlist, pages) < 0) { > PyErr_SetFromErrno(PyExc_OSError); > return NULL; > } > -- > 2.10.1 >